1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/calls.git synced 2024-09-21 10:55:24 +00:00
Commit graph

1955 commits

Author SHA1 Message Date
Evangelos Ribeiro Tzaras
29c797ebb8 ci: Update image
The new image includes new versions of our dependencies.
This is needed as we require newer feedbackd packages.
2022-12-03 08:52:41 +00:00
Evangelos Ribeiro Tzaras
76e640c826 run-docker: Don't cache container images
Without --no-cache newly "built" images end up just creating a new tag
for old images, see below.

$ podman images
REPOSITORY                                    TAG            IMAGE ID      CREATED       SIZE
registry.gitlab.gnome.org/gnome/calls/debian  v0.0.20221013  a1c2d79e4f72  4 weeks ago   1.53 GB
registry.gitlab.gnome.org/gnome/calls/debian  v0.0.20221117  4d2a38aa5bff  3 months ago  2.01 GB
registry.gitlab.gnome.org/gnome/calls/debian  v0.0.20220817  4d2a38aa5bff  3 months ago  2.01 GB
2022-12-03 08:52:41 +00:00
Evangelos Ribeiro Tzaras
f1c9701d1b flatpak: Bump required feedbackd version to 0.0.1 2022-12-03 08:52:41 +00:00
Evangelos Ribeiro Tzaras
92e005ac85 d/control: Bump required feedbackd version to 0.0.1
The latest changes to the ringer require fixes made available in 0.0.1
2022-12-03 08:52:41 +00:00
Evangelos Ribeiro Tzaras
d3a93bd66a gcovr: Exclude sip-provider.c and dummy-provider.c
gcovr > 5.1 (which is included in the latest Debian CI image) fails an
assertion because two different functions with the same name end up on
different lines because they are #ifdef'ed

The offending code is this:

G_DEFINE_TYPE_WITH_CODE
  (CallsDummyProvider, calls_dummy_provider, CALLS_TYPE_PROVIDER,
  G_IMPLEMENT_INTERFACE (CALLS_TYPE_MESSAGE_SOURCE,
                         calls_dummy_provider_message_source_interface_init))

G_DEFINE_DYNAMIC_TYPE_EXTENDED
  (CallsDummyProvider, calls_dummy_provider, CALLS_TYPE_PROVIDER, 0,
   G_IMPLEMENT_INTERFACE_DYNAMIC (CALLS_TYPE_MESSAGE_SOURCE,
                                  calls_dummy_provider_message_source_interface_init))

There is already a gcovr issue here:
https://github.com/gcovr/gcovr/issues/586

The failed assertion looks like this:

Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/gcovr/workers.py", line 78, in worker
    work(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/gcovr/gcov.py", line 337, in process_datafile
    done = run_gcov_and_process_files(
  File "/usr/lib/python3/dist-packages/gcovr/gcov.py", line 514, in run_gcov_and_process_files
    process_gcov_data(fname, covdata, abs_filename, options)
  File "/usr/lib/python3/dist-packages/gcovr/gcov.py", line 165, in process_gcov_data
    insert_file_coverage(covdata, coverage)
  File "/usr/lib/python3/dist-packages/gcovr/merging.py", line 159, in insert_file_coverage
    return _insert_coverage_item(target, file.filename, file, merge_file, options)
  File "/usr/lib/python3/dist-packages/gcovr/merging.py", line 135, in _insert_coverage_item
    merged_item = merge_item(target_dict[key], new_item, options)
  File "/usr/lib/python3/dist-packages/gcovr/merging.py", line 178, in merge_file
    left.functions = _merge_dict(
  File "/usr/lib/python3/dist-packages/gcovr/merging.py", line 99, in _merge_dict
    _insert_coverage_item(left, key, right_item, merge_item, options)
  File "/usr/lib/python3/dist-packages/gcovr/merging.py", line 135, in _insert_coverage_item
    merged_item = merge_item(target_dict[key], new_item, options)
  File "/usr/lib/python3/dist-packages/gcovr/merging.py", line 268, in merge_function
    assert left.lineno == right.lineno
AssertionError
2022-12-03 08:52:41 +00:00
Boyuan Yang
ff69273e20 Add Chinese (China) translation 2022-11-29 21:42:11 +00:00
Asier Sarasua Garmendia
5f3c908284 Add Basque translation 2022-11-29 18:19:27 +00:00
Kukuh Syafaat
4607cf7593 Update Indonesian translation 2022-11-29 04:42:47 +00:00
Aleksandr Melman
f40b8991fb Update Russian translation 2022-11-28 04:32:45 +00:00
Jiri Grönroos
7b5be5a3ee Update Finnish translation 2022-11-26 21:30:36 +00:00
Hugo Carvalho
f1be3df35c Update Portuguese translation 2022-11-24 14:04:10 +00:00
Yosef Or Boczko
1bf420d2de Update Hebrew translation 2022-11-24 09:04:58 +00:00
Balázs Úr
22c3d9d050 Update Hungarian translation 2022-11-22 23:47:21 +00:00
Vittorio Monti
00c27646cf Update Italian translation 2022-11-21 08:20:12 +00:00
Daniel Șerbănescu
d3b4fb12a7 Update Romanian translation 2022-11-20 17:59:00 +00:00
Piotr Drąg
7c287ca6c1 Update Polish translation 2022-11-20 14:54:50 +01:00
Дилян Палаузов
dee7e1b9ae provider/sip: on_origin_pw_looked_up() display_name is read twice 2022-11-20 12:51:23 +00:00
Anders Jonsson
a830b45d2f Update Swedish translation 2022-11-19 19:45:00 +00:00
Zurab Kargareteli
ff274081fd Update Georgian translation 2022-11-19 05:28:54 +00:00
Yuri Chornoivan
8143e37995 Update Ukrainian translation 2022-11-19 04:49:34 +00:00
Evangelos Ribeiro Tzaras
0ead013d4d account-overview: Set window title
Set window title for the overview as well for adding or editing an account.
2022-11-18 13:49:47 +00:00
Evangelos Ribeiro Tzaras
7135d02e3e account-overview: Close windows when pressing Escape
Closes: #511
2022-11-18 13:49:47 +00:00
Дилян Палаузов
90228e968c SIP dial() convert the port from int to string 2022-11-18 13:48:55 +00:00
Evangelos Ribeiro Tzaras
19f8ac390b application: Shut down graceful on SIGTERM/SIGINT
This will allow cleaning up after ourselves, e.g. closing the record DB.

Fixes: #508
2022-11-17 10:00:03 +01:00
Evangelos Ribeiro Tzaras
e1f0b83d25 ringer: Break loop if triggered event was ended immediately
When the only feedback of an event is unavailable on a system (e.g. no
vibration motor or LED) the "feedback-ended" signal is emitted
immediately and the end reason will be LFB_EVENT_END_REASON_NOT_FOUND.

In this case we need to change the target state, so that our logic does
not end up retriggering the event infinitely.
2022-11-15 09:52:17 +00:00
Evangelos Ribeiro Tzaras
e52f327aae ringer: Cancel async libfeedback calls on timeout
If libfeedback has not finished triggering/ending a feedback after one
second we give up and set an error state.
2022-11-15 09:52:17 +00:00
Evangelos Ribeiro Tzaras
1056cba62a ringer: Never cancel async DBus calls and refactor
Previously our code assumed that g_cancellable_cancel() the async DBus
calls to libfeedback would guarantee that the underlying operation would
not be performed (i.e. triggering or ending a feedback).

However the endless ringing exhibited in #470 shows this assumption not
to hold. Therefore we avoid using g_cancellable_cancel () completely and
default to waiting for the async operation to finish.

update_ring () now sets the target state by inspecting managed calls and
the main logic will now step towards the target state:
Changing from regular/loud to soft/quiet ringing (or vice versa)
requires we first end feedback before (re)triggering it.

Additionally the "is-quiet" and "is-ringing" properties are replaced by
a new "state" property to allow changing the combination atomically.

Closes: #470
2022-11-15 09:52:17 +00:00
Evangelos Ribeiro Tzaras
43353d48a3 mock-lfb-event: Emit "feedback-ended" signal
This emulates lfb behaviour and the ringer will rely on this behaviour
when ending feedbacks.
2022-11-15 09:52:17 +00:00
Evangelos Ribeiro Tzaras
c0183d740e mock-lfb-event: Uncrustify 2022-11-15 09:52:17 +00:00
Evangelos Ribeiro Tzaras
baee7dbc89 test-ringer: Assert object finalization
This helps catching any dangling references.
2022-11-15 09:52:17 +00:00
Evangelos Ribeiro Tzaras
662befeb48 mm-provider: Cancel ongoing operations
both when MM has appeared on DBus and
when disposing of the provider.
2022-11-08 13:40:37 +00:00
Evangelos Ribeiro Tzaras
79401f6227 contact-provider: Allow can-add-contacts to be reset
Under normal conditions it is not expected that whether we can add
contacts or not (based on the presence of the appropriate action on
gnome-contacts) changes.

Nevertheless it can be beneficial for debugging when installing patched
and unpatched versions of gnome-contacts.
2022-11-08 11:28:18 +00:00
Evangelos Ribeiro Tzaras
b948629274 contacts-provider: Remove unused variable 2022-11-08 11:28:18 +00:00
Evangelos Ribeiro Tzaras
352a7852f6 ui-call-data: Prevent timer being started multiple times
Fixes #502
2022-11-05 23:51:19 +00:00
Evangelos Ribeiro Tzaras
9b0b1741cc ui-call-data: Add debugging for state changes
This should help fixing issues like #502 in the future.
2022-11-05 23:51:19 +00:00
Evangelos Ribeiro Tzaras
9d63f8961c sip-origin: Honour set port when completing address
This makes sure to include the port when dialing the short form.

Fixes: #506
2022-11-04 10:00:02 +00:00
Evangelos Ribeiro Tzaras
563ceb770c media-pipeline: Dump dot graph without GST_DEBUG_DUMP_DOT_DIR set
gst_debug_bin_to_dot_file() NOOPs if GStreamer was initialized without
the enviroment variable GST_DEBUG_DUMP_DOT_DIR.

If SIGUSR2 was signalled we want to have a dot file dumped no matter
what. Functions for asynchronously writing the graph as obtained by
gst_debug_bin_dot_data() to a temporary file and print the path to
stdout.

Note: Usage of GST_DEBUG_BIN_DOT_FILE() on pipeline state change is left
as is, because we don't want to dump graphs for every change on every
pipeline.
2022-11-01 12:25:43 +00:00
Evangelos Ribeiro Tzaras
9dd3066649 sip: media-manager: Simplify SDP generation
Use the newly added get_address_family().
2022-11-01 11:04:35 +00:00
Evangelos Ribeiro Tzaras
1deee0b71b util: Add API to check address family of IP address 2022-11-01 11:04:35 +00:00
Evangelos Ribeiro Tzaras
29a2059e0e util: Rename function to calls_find_in_model() and adjust documentation
Since it works for GListModel rename it appropriately.

It used to provide an inline implementation for g_list_store_find()
behind a glib version guard, but we bumped minimum version in
cfd3c2a7fe
so the docstring was updated and made more succinct.
2022-11-01 11:04:35 +00:00
Evangelos Ribeiro Tzaras
0bcf3fa08e util: Remove unused code 2022-11-01 11:04:35 +00:00
Evangelos Ribeiro Tzaras
1489cfa796 test-util: Remove unused include 2022-11-01 11:04:35 +00:00
Evangelos Ribeiro Tzaras
f7e632dcb4 application: Propagate verbosity to main instance
If another instance of calls was already running, invoking calls with
`-v` flag would set the verbosity for the newly created process and then
exit if it was not the primary instance.
2022-11-01 10:19:08 +00:00
Evangelos Ribeiro Tzaras
a5eb750350 log: Use unsigned int for verbosity
Negative verbosity levels don't make sense.
2022-11-01 10:19:08 +00:00
Evangelos Ribeiro Tzaras
a278cb660c application: Fix indentation 2022-11-01 10:19:08 +00:00
Balázs Úr
e7d331ba8f Update Hungarian translation 2022-10-27 20:15:08 +00:00
Daniel Rusek
0924932dba Update Czech translation 2022-10-17 13:43:29 +00:00
Evangelos Ribeiro Tzaras
8173d4a9ee new-call-box: Reindent 2022-10-13 13:24:19 +00:00
Evangelos Ribeiro Tzaras
8a16439cc8 new-call-box: Switch to using CuiDialpad
It has been in libcall-ui for some time, so let's use it.

This will also easy the transition to Gtk4 as it's one less widget we
have to worry about.
2022-10-13 13:24:19 +00:00
Evangelos Ribeiro Tzaras
8cdd017c2f Revert "Disable g722 to avoid test failure with ffmpeg 5.0/gst-libav"
This reverts commit 857c375ab9.

The failure to register types due to invalid type names seems to be
resolved, so let's revert to reenable g722 codecs.
2022-10-12 23:18:13 +02:00