1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/calls.git synced 2024-11-12 19:41:18 +00:00
Commit graph

1828 commits

Author SHA1 Message Date
Дилян Палаузов
267eecf049 srtp-utils: Add support for AES 256 bit crypto suites
As specified by RFC 6188.
2023-05-09 13:23:43 +00:00
Дилян Палаузов
8ca3597646 sdp-crypto: Include "ICM" in crypto suite enums
This indicates integer counter mode being used and
helps disambiguate additional crypto suites in the future.

Renamed CALLS_SRTP_SUITE_AES_128_SHA1_80 → CALLS_SRTP_SUITE_AES_128_ICM_SHA1_80
and CALLS_SRTP_SUITE_AES_128_SHA1_32 → CALLS_SRTP_SUITE_AES_128_ICM_SHA1_32
2023-05-09 13:23:43 +00:00
Дилян Палаузов
e6bfa6d933 srtp-utils: Reuse existing function to get expected key length
This avoids unnecessary and potentially error-prone duplication.
2023-05-09 13:23:43 +00:00
Дилян Палаузов
3db2c5dbb9 srtp-utils: Add implicit padding characters explicitly
Otherwise base64 decoding will give us a wrong key.
2023-05-09 13:23:43 +00:00
Дилян Палаузов
cfd371d72e srtp-utils: Strip padding characters in crypto attribute lines
https://www.rfc-editor.org/rfc/rfc4568.html#section-6.1 says:
 When base64 decoding the key and salt, padding characters (i.e.,
 one or two "=" at the end of the base64-encoded data) are discarded
 (see [RFC3548] for details).

https://www.rfc-editor.org/rfc/rfc3548#section-2.2 says:
 In some circumstances, the use of padding ("=") in base encoded data
 is not required nor used.  In the general case, when assumptions on
 size of transported data cannot be made, padding is required to yield
 correct decoded data.
2023-05-09 13:23:43 +00:00
Evangelos Ribeiro Tzaras
037d2c55f6 srtp-utils: Pass MKI length into error message
Fixes: 4937723541
2023-05-09 09:23:39 +00:00
Evangelos Ribeiro Tzaras
509456cb50 ci: Build tarball for tags 2023-05-09 07:44:09 +00:00
Evangelos Ribeiro Tzaras
e80abf713a tests: Use g_test_init instead of gtk_test_init
gtk_test_init() ends up calling gtk_init() which tries opening
the default display. CI jobs sometimes seem to trip over this
even when run through xvfb-run. Therefore we use g_test_init()
instead.
2023-05-09 07:44:09 +00:00
Evangelos Ribeiro Tzaras
b550617de2 ci: Allow flatpak jobs to fail
They have been a bit flaky lately, especially the arm64 job.
2023-05-09 09:16:11 +02:00
Дилян Палаузов
8eb46de6f9 srtp-utils: Remove unused variable srtp_crypto_suites 2023-05-03 17:05:58 +02:00
Florian Weimer
4fa542751b test-sip: Use su_random() (not su_random64())
su_random64() is not exposed in the freeswitch fork of sofia-sip.
2023-05-03 14:40:22 +00:00
Evangelos Ribeiro Tzaras
61b81a285c mm-provider: Don't warn about cancelled mm_manager_new()
It is cancelled when disposing and does not warrant a warning.
2023-05-01 09:35:10 +02:00
Fabio Tomat
958d63dfab Update Friulian translation 2023-04-28 08:36:57 +00:00
Evangelos Ribeiro Tzaras
e9452a394a Document and release 45~alpha.0 2023-04-25 11:19:18 +02:00
Yosef Or Boczko
ae19378c5b Update Hebrew translation 2023-04-21 09:29:42 +00:00
Evangelos Ribeiro Tzaras
c6ea3adf64 manager: Respect object life cycle for signal handlers 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
f7dd62c0bd contacts-provider: Disconnect signals on finalize 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
c7ba302b18 account-row: Guard calls_account_row_new() against invalid provider 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
4576547c20 sip-origin: Prefer named constant over magic numbers 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
5362d1c975 sip-origin: Don't leak address 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
0e753816c9 sip-origin: Include SIP address in debugging
This makes it easier to see if all accounts are being disposed
2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
f7745f50bd sip-origin: Keep sofia running to allow unregistering on dispose
sofia-sip needs to keep iterating its' main loop in order to
unregister as well as process the response from the server.

Closes: #554
2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
8b3eccd1b7 sip-origin: Use g_clear_pointer() instead of emulating it 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
3076f913e7 manager: Clear providers after origins
Fixes a segmentation fault on shutdown in nua_unregister()
2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
23e9cca320 main-window: Use gtk_widget_destroy() for windows
Top level widgets should typically call gtk_widget_destroy()
2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
47bb3aaa62 account-overview: Respect object life cycle for signal handlers
Prevents the following failed assertion when shutting down Calls:

CallsAccountOverview:ERROR:../src/calls-account-overview.c:222:update_account_list: assertion failed: (CALLS_IS_ACCOUNT_OVERVIEW (self))
2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
34d4e854bc manager: Respect object life cycle for signal handlers
Don't call signal handlers after the manager has been disposed.
2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
f485215a9f application: Initialize objects before parsing options
This helps making object life cycles clearer and
with logging already set up we won't miss any early debugging messages.
2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
d690fe5f68 application: Handle setting verbosity first
We want logging verbosity to be set before other command line options
are handled as we might be missing messages otherwise.
2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
813103e684 application: Don't leak CallsManager 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
2f3f55c831 new-call-box: Don't leak CallsOrigin
get_selected_origin () does not need to take a reference on CallsOrigin
2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
ea5d7038e7 new-call-box: Use STR_IS_NULL_OR_EMPTY macro 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
0452d8a2bf manager: Use STR_IS_NULL_OR_EMPTY macro 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
3e43ba2975 call-window: Remove dead code 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
2550141585 application: Remove unused macro 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
12161080bc test-manager: Remove unused include 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
62f6f75667 test-manager: Remove unused variable 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
4e900e1ac5 main-window: Codestyle 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
0261271560 main-window: Sort includes 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
9ff06561e8 resources: Sort alphabetically 2023-04-18 08:34:39 +00:00
Evangelos Ribeiro Tzaras
0cb25d9e3c build: Sort enum headers 2023-04-18 08:34:39 +00:00
Sabri Ünal
f3e6c2c7c3 Update Turkish translation 2023-04-17 15:09:22 +00:00
Balázs Úr
7dc0fb027a Update Hungarian translation 2023-04-13 21:30:41 +00:00
Evangelos Ribeiro Tzaras
cf52fbba67 test-contacts: Add more test cases
Testing lookup of both empty string and NULL ensures we won't regress.
2023-04-13 06:01:05 +00:00
Evangelos Ribeiro Tzaras
23ee0475dd best-match: Don't special case NULL best match
We always get a valid best match, even for NULL or empty ids,
so there is no more need to special case it.
2023-04-13 06:01:05 +00:00
Evangelos Ribeiro Tzaras
830906f57a contacts-provider: Handle NULL and empty strings graceful in lookup
Fixes a crash where we asserted on best match when the id was NULL or
empty.

Closes: #567
2023-04-13 06:01:05 +00:00
Evangelos Ribeiro Tzaras
10d74634ba contacts-provider: Simplify refcounting in lookup_id()
g_autoptr usage was a bit pointless here since
calls_contacts_provider_lookup_id() is transfer full
2023-04-13 06:01:05 +00:00
Evangelos Ribeiro Tzaras
ac2dc8573d best-match: Add gtk-doc annotations to the public API
Notably this adds ownership and nullable annotations, where appropriate.
2023-04-13 06:01:05 +00:00
Evangelos Ribeiro Tzaras
3fb016f6b2 best-match: Allow both NULL and empty strings as phone number
This allows us to get rid of some special casing when retrieving
primary and secondary display information.
2023-04-13 06:01:05 +00:00
Evangelos Ribeiro Tzaras
94cfbd83b2 sip-provider: Chain up to constructed early 2023-04-12 09:17:40 +00:00