When build wifi driver based on next-20230224 Linux code, will observe
the following build errors.
/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_shim.c: In function ‘moal_recv_event’:
/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_shim.c:3475:25: error: too few arguments to function ‘cfg80211_ch_switch_notify’
3475 | cfg80211_ch_switch_notify(priv->netdev, &priv->chan, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_main.h:123,
from /work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_shim.c:28:
./include/net/cfg80211.h:8375:6: note: declared here
8375 | void cfg80211_ch_switch_notify(struct net_device *dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:252: /work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_shim.o] Error 1
make[1]: *** [Makefile:2028: /work/mwifiex/mxm_wifiex/wlan_src] Error 2
make[1]: Leaving directory '/work/linux-nxp-rebase'
This is caused by kernel patch b345f0637c00("wifi: cfg80211: include
puncturing bitmap in channel switch events"), now
cfg80211_ch_switch_notify() needs four parameters.
Note: The patch was introduced in L6.2 kernel next tree, but in L6.3
kernel linus tree, so maybe you need to change the kernel version to
L6.3 after we rebase the linux-nxp-rebase to L6.3.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
When build wifi driver based on next-20230119 Linux code, will observe
the following build errors.
/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_eth_ioctl.c: In function ‘woal_priv_get_ap’:
/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_eth_ioctl.c:5968:39: error: invalid application of ‘sizeof’ to incomplete type ‘char[]’
5968 | sizeof(mwr->u.ap_addr.sa_data));
| ^
make[2]: *** [scripts/Makefile.build:252: /work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_eth_ioctl.o] Error 1
make[1]: *** [Makefile:2027: /work/mwifiex/mxm_wifiex/wlan_src] Error 2
make[1]: Leaving directory '/work/linux-nxp-rebase'
This is caused by kernel patch b5f0de6df6dc("net: dev: Convert sa_data
to flexible array in struct sockaddr"), now anything using
sizeof(sa->sa_data) must switch to sizeof(sa->sa_data_min).
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
SCR.txt and LICENSE files should be in root folder, also need to rename
the gpl-2.0.txt file to work better with GitHub.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Driver Bug Fixes:
-----------------
1. WSW-23826: DUT is not waking up on Boadcast Event
2. WSW-22873: Random Kernel crash is seen in STAUT RSNE bounds verification using WPA2-Enterprise test
3. WCSWREL-400: Fixed kernel panic during FW reload
4. WSFD-599: Support trigger frame generating in RF test mode
5. WSW-23330: Auto Go can't bring up after auto Fw reload
6. WSW-23920: DUT fails to send NA packet in response NS packet during ipv6 NSoffload when host sleep is enabled
7. WSW-23938: Wi-Fi stuck after cmd53 read error=-84
8. WSW-22765: Fixed the issue of WPA2-Enterprise STA test fails
9. WSW-24932: Random Wifi hang Issue with error wakeup card timeout is observed during coex scenario
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Driver Bug Fixes:
-----------------
1. WCSWREL-386: wifi cannot re-connect to AP automatically after resume back
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Driver Bug Fixes:
-----------------
1. WSW-22601: kernel warning are seen on STAUT when Channel switch command is executed on Ex-AP
2. WSW-22845: hotspot start fail in function test from Android GUI
3. WSW-22456: APUT is not sending ECSA Action frames when channel_switch command is executed with ECSA Action frame enabled
4. WCSWREL-372: Kernel difference between Linux 5.15 and Android 13 cause Wi-Fi driver compilation failure
5. WSW-17873: Remove big endian flag from makefile
6. WSW-22457: APUT is not switching to new channel when channel_switch command is executed in 2.4 GHz
7. WSW-22313: 0xa9 cmd timeout on fw reload
8. WCSWREL-375: merge the fix patch for the build errors with the API changes on next-20220912 kernel tag
9. WSW-22361: Change the state of Timer function in mxmdriver
10. WSW-22207: Kernel Panic when run timeout IR stress on iMX8 Platform
11. WSFD-559: Support Wi-fi Auto Recovery in Linux driver
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
The prandom_u32() function has been a deprecated inline wrapper around
get_random_u32() for several releases now, and compiles down to the
exact same code. Replace the deprecated wrapper with a direct call to
the real function.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Driver Bug Fixes:
-----------------
1. WSW-19892: Driver compilation errors on older kernel version
2. WSW-19638: Enable RF Test Mode support for 9098 PCIE and SDIO
3. WCSWREL-370: oob irq request fail on i.MX93 9x9 qsb board
4. WSW-21756: WLAN Driver hang observed during WiFi connect/disconnect
5. WCSWREL-362: merge the L6.0.0 build errors fix patches
6. WSW-22054: STA CSA event is not propagated to cfg80211
7. WSW-21873: STA does not send probes after switching from DFS channel
8. WSW-21530: UDP Tx not able to send ARP when high bandwidth is used
9. WSW-21541: WFA Pre-Cert Channel switch test is failing
10. WSW-21072: AP stops sending CTS-to-Self in mcast Tx after issue mc_aggr_cfg
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
b48b89f9c189 ("net: drop the weight argument from netif_napi_add") patch
in upstream kernel change the netif_napi_add API, so corresponding
functions used in wifi driver also need to be changed to avoid build
break. Now this API change is based on the next-20220930 kernel tag.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Kernel cfg80211 add link_id parameter to various key operations for
MLO, for more details, please check the following link:
https://lore.kernel.org/all/20220730052643.1959111-4-quic_vjakkam@quicinc.com/
As these API changes on next-20220912 kernel tag, corresponding
functions also need to be changed to avoid build break.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
i.MX93 9x9 qsb board connect the out-of-band WoWLAN irq pin(M.2 pin21
SDIO_WAKE) to I2C IO expander pcal6524 instead of i.MX GPIO, pcal6524
IRQ handlers need to be threaded, and the IRQ trigger type depends on
the devicetree setting. Also the IRQF_ONESHOT flag need to be set for
threaded IRQ.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Reviewed-by: Haibo Chen <haibo.chen@nxp.com>
Driver Bug Fixes:
-----------------
1. LF-6972: Updated the License to GPL-2.0
2. Incremented the driver version
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Driver Bug Fixes:
-----------------
1. WSW-21217: Wifi driver crash at woal_ring_poll_worker during PDn recovery test
2. WSW-21020: Enable host_mlme by default
3. WSW-20532: Resolved CSA IE not present in beacon when injecting chirp type radar
4. WSW-21085: Link measurement bit not set in RRM Cap IE
5. WSW-17940: Kernel crash is seen randomly during STA/P2P testing
6. WSW-19320: Testcases from VtsHalWifiV1_3TargetTest suite are failing
7. WSW-21164: Fix driver crash issue caused by null ring buffer of wifi logger
8. WSW-19335: RSN Extension IE is not included in Assoc req when AP side does not connect via WPA3 R3
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
There are many cfg80211 common api and struct changes on next-20220719
kernel tag, which is based on v5.19-rc7 Linus tree tag with the for-next
branch patches on each kernel IP repo, target for v6.0 kernel version.
So need to change the local wifi driver accordingly to avoid the build
errors.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Signed-off-by: Zhipeng Wang <zhipeng.wang_1@nxp.com>
Driver Bug Fixes:
-----------------
1. WCSWREL-352: Fixed WiFi driver kernel panic with "use after free" print
2. WCSWREL-353: Fixed WiFi driver panic when switch AP to another AP
3. WCSWREL-337: merge the L5.18 build errors and warnings fix patches into next wifi release
4. WSW-16518: Fixed STA going to unresponsive state during basic UAPSD operation
5. WSW-19350: Observed "unexpected kernel BRK exception" in STA 2G VHT with BT HID traffic running simultaneously
6. WSW-19640: cannot enable the "20/40 BSS Coexistence Management" support
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Driver Bug Fixes:
-----------------
1. Added GPL/NXP dual license header
2. WCSWREL-242: Fixed system rebooted issue after connecting wifi and running bt A2DP stress
3. WCSWREL-310: merge the L5.17 build errors and warnings related to netif_rx
4. WCSWREL-317: merge the build error and warning fix related to eth_hw_addr_set
5. WSW-19664: Fixed VtsHalWifiV1_0TargetTest failure
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
L5.18 kernel removed the wrappers in include/linux/pci-dma-compat.h, so
need to switch from 'pci_dma' to 'dma_' API.
Also, to make it unambiguous that mmc_hw_reset() is for cards and not
for controllers, L5.18 kernel make the function argument mmc_card
instead of mmc_host.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
When build the mxm17322 wifi release based on the latest kernel(L5.17),
will observe the following build warning.
Need to use eth_hw_addr_set function instead of writing the address
directly to net_device::dev_addr. Make sure we don't cast off const
qualifier from dev->dev_addr.
/home/sherry/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_uap_cfg80211.c: In function ‘woal_cfg80211_add_mon_if’:
/home/sherry/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_uap_cfg80211.c:1485:44: warning: passing argument 2 of ‘moal_memcpy_ext’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
1485 | moal_memcpy_ext(priv->phandle, ndev->dev_addr, ndev->perm_addr,
| ~~~~^~~~~~~~~~
In file included from /home/sherry/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_main.h:119,
from /home/sherry/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_cfg80211.h:26,
from /home/sherry/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_uap_cfg80211.c:23:
/home/sherry/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_shim.h:82:48: note: expected ‘t_void *’ {aka ‘void *’} but argument is of type ‘const unsigned char *’
82 | t_void *moal_memcpy_ext(t_void *pmoal, t_void *pdest, const t_void *psrc,
| ~~~~~~~~^~~~~
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
mxm17322 deleted the mapp/mlanconfig/Makefile, it may cause the build
error when run the "$(MAKE) -C mapp/mlanconfig $@ INSTALLDIR=$(BINDIR)"
command in topmost Makefile.
So add the mapp/mlanconfig/Makefile back here.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
New Additions/Removals/Improvements:
------------------------------------
1. WSW-18868: Improve FW download time after suspend/resume cycle
2. WSFD-484: WIFI 6E support
3. WSW-17954: Enable turbo mode command for mlanutl
4. WSW-19363: Add debug prints to WLAN driver regarding WPA_supplicant
5. WSW-19307: Support robust btc related commands [0x00e0] in mlanutl
6. WSW-16429: Disabling of WEP/TKIP on all V16 devices
7. Use CFG80211_VERSION_CODE to control cfg80211 related code
8. Enabled these new commands for mlanutl: min_ba_threshold, stop_su and ed_mac_ctrl_v3
9. WSFD-386: FW and VHAL Implementation for WOWLAN by adding code for MDNS wakeup
Driver Bug Fixes:
-----------------
1. WSW-18708: Setting domain info fails for W8801 Murata M.2 Module (2DS)
2. WSW-18541: Debug logs not seen if drvdbg is part of wifi_mod_para.conf
3. WSW-19136: Command 0x107 timeout is seen radomly during connect-disconnect test
4. WSW-18865: VHT80 TCP-tx throughput only run about 170Mbps, both STA and MMH mode
5. WSW-17923: 4K Video Stoppage Issue, Wi-Fi throughput drops to lower than 20Mbps without recovery
6. WSW-17925: NO_IR flags are not cleared for ch 12,13 and 14 if country is changed to JP in runtime
7. WCSWREL-251: There is "mlan0: Failed to initialize driver interface" during stress load/unload testing
8. WSW-18431: UAP beacon (in 1x1 mode) not reporting correct values for tx_highest_rate and rx_highest_rate in VhtCap IE
9. WSW-18116: TCP Keep alive packets are not seen after starting cloud keep alive
10. WSW-18690: STAUT is advertising support of MCS-0 to 9 only in HE-IE in Probe Request
11. WCSWREL-266: Fix L5.16 build errors and warnings
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Since kernel commit baebdf48c3600 ("net: dev: Makes sure netif_rx() can
be invoked in any context.")
the function netif_rx() can be used in preemptible/thread context as
well as in interrupt context.
Use netif_rx().
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
Use eth_hw_addr_set function instead of writing the address directly to
net_device::dev_addr. Make sure we don't cast off const qualifier from
dev->dev_addr. Otherwise will have the build warnings when build the
driver based on L5.16 kernel.
Fixes: adeef3e32146 ("net: constify netdev->dev_addr")
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
L5.16 kernel patch commit a1c11021f19cb0a80f removed the PDE_DATA() and
replace it with pde_data(), so need to change accordingly, otherwise
will have the driver build errors.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
changes:
1. WSW-18043: Include txpwrlimit_cfg_iw416 files on MM driver
2. WSW-18325: Rename ed_mac_ctrl conf files from V3 to V2
3. WSW-16931: Observing timeout on STAUT with UL OFDMA BSR scenario
4. WCSWREL-227: Fixed the issue of CtsWifiTestCases case android.net.wifi.cts.WifiManagerTest#testTrafficStateCallback
5. WSW-17727: Fixed the issue of STA Connection failed with dmcs enable and host_mlme=1
6. WSW-17450: Fixed the issue of android.net.wifi.cts.WifiManagerTest failure
7. WSW-17491: Fixed the issue of android.cts.statsdatom.wifi.WifiStatsTests failure
8. WSW-18006: Set CAC period of 600 sec for weather channel for ETSI region
9. WSW-17906: Fixed the issue of APUT not advertise the support of MCS32
10. WSW-17575: Fixed the issue of Host cannot wake-up by ping during Hostsleep
11. WSW-17904: Fixed the issue of STAUT advertising VHT Tx/Rx MCS as 1SS when associating with 1SS AP
12. WSW-17427: Fixed the issue of uAPUTL failing to start BSS and returns "Core Dumped" error message
13. WSW-15856: Hotspot is turning off automatically after few minutes ~10mins with one client connected
14. WCSWREL-211: System reboot when switch wifi hotspot security mode from WPA2 to none
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
Added missing ed_mac conf file for 8978 and also removed ed_mac conf
file of 9177 and 909x which is not a supported SoC on IMX under
MassMarket.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
changes:
1. WCSWREL-199: Fixed the build error on kernel higher than L5.12
2. WSW-16639: Improve the throughput by avoiding skb copy in amsdu deaggreation
3. WSW-15903: By default enabled pmqos=1 module param on IMX8 only and disable this for other platforms like X86
4. WSFD-411: Generate fw_dump files in HAL layer instead of driver
5. WSW-17154: Fixed the issue of driver crash seen with AGO+AGO restart stress test
6. WSFD-416: Added WPA3 R3 support using embedded supplicant
7. WSW-16171: Fixed the issue of DUT failed to roam to other AP2, when low RSSI hits on connected AP1
8. WSW-17323: Fixed the issue of not activating Channel 13 using DE or JP country codes
9. WSW-16630: APUT is not switching back from 20/40MHz to 20MHz channel bandwidth in the presence of 20MHz testbed AP
10. WCECCB-37: Added support for UNII-4 / upper 5 GHz channels
11. WSW-17368: Fixed the issue of System shutdown after switching AC power to battery
12. WSW-17447: Added RTT support enablement for Android
13. WSW-17453: Fixed the issue of 0x107 Command timeout for scan(iwlist)
14. WSW-17019: Fixed the issue of Wifi hang with timeout cmd id 0x20 due to interference from another device doing DPD
15. WSW-14: Added Support for IMX Linux Kernel 5.15.0
16. WSW-17450: Disable host based Link layer stats so that fw based stats will be used
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
changes:
1. Enabled pmqos by default for IMX platforms
2. WCSWREL-186: Merged a fix to avoid mlanutl tool to fail on kernel higher than L5.15
3. Fixed kernel crash dump warning message when invoking pm_qos_add_request
or pm_qos_remove_request APIs in case of dual MAC SoC like Skyhawk
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
The parameters in cfg80211_unregister_netdevice function is wrong, will
cause the build error on kernel higher than L5.12.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
ndo_siocdevprivate should use woal_uap_do_ioctl instead of woal_do_ioctl
in woal_uap_netdev_ops struct.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
changes:
1. WCSWREL-191: Fixed the error when loading module param from user config for SD8801
2. WCSWREL-186: Fixed the issue of mlanutl failing on kernel higher than L5.15
3. Fixed low throughput issue for WPA3 SAE
4. Added driver change for WLAN throughput improvement on 8997 SoC
5. Updated README to recommend not to use WEP/TKIP for all chipsets
6. WCSWREL-180: Fix P2P test fail on kernel higher than L5.12
7. WCSWREL-156: kernel_write/kernel_read not allowed by drivers for L5.10 kernel GKI buildou
8. Alternative for pm_qos_add_request/pm_qos_remove_request
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
When use mlanutl on L5.15, will meet below error logs:
root@imx8mqevk:/usr/share/nxp_wireless# ./mlanutl mlan0 hssetpara 2 0xff 0xc8 3 400
mlanutl: Operation not supported
mlanutl: hssetpara fail
This is due to the net common api change the ndo_do_ioctl behavior, it
splits out all the users of SIOCDEVPRIVATE ioctls into a separate
ndo_siocdevprivate callback. All the ioctl functions through
SIOCDEVPRIVATE in mlanutl.c will fail if not follow this upstream api
change. So here change to use new ndo_siocdevprivate instead of
ndo_do_ioctl on L5.15.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
changes:
1. Remove unsupported commands and info from README_MLAN.
2. Improved the 8997 SDIO TCP Tx throughput.
3. 0x10c Command Timeout during p2p_connect
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
P2P test will fail(deadlock) on kernel higher than L5.12,
error log like below:
root@imx8mmevk:~# wpa_cli -i p2p0 p2p_group_add freq=2412
[ 47.284346] Add virtual interface p2p-p2p0-0
'P2P_GROUP_ADD freq=2412' command timed out.
This is because the upgarded kernel change the netdevs
registration/unregistration semantics, new kernel require the drivers
to call cfg80211_(un)register_netdevice() when this is happening due to
a cfg80211 request.
For more details, please refer to the upstream patch:
https://lore.kernel.org/linux-wireless/20210122161942.cf2f4b65e4e9.Ida8234e50da13eb675b557bac52a713ad4eddf71@changeid/
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
For the wifi release 17266, we found SDIO8987 and PCIE8997 both may meet
below error logs when run suspend stress test.
"HS not actived, suspend fail!"
For pcie8997 on imx8mp, this may cause system hang. For sdio8987 and
pcie8997 on other platforms, this may cause suspend fail sometimes.
This patch is a workaround for this issue. WCS team still debugging this
issue.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
changes:
1. WCSWREL-126: Fixed PCIE9098 suspend fail on imx8mq.
2. WCSWREL-87: Hostsleep fails as DUT doesnot wake up on traffic/pattern.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Approved-by: Tian Yang <yang.tian@nxp.com>
changes:
1. Fixed Mu-MIMO not working issue.
2. Added a workaround for suspend-resume failure to block suspend when
WLAN is in connected state.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Reviewed-by: yang.tian <yang.tian@nxp.com>
changes:
1. Fixed compilation errors for 5.12 kernel.
2. Fixed an issue with suspend/resume for PCIE9098 with 5.10.9 kernel.
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Reviewed-by: yang.tian <yang.tian@nxp.com>
meet below build error log:
/home/sherry/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_pcie.c: In function ‘woal_request_pmqos_busfreq_high’:
/home/sherry/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_pcie.c:143:31: error: ‘woal_pcie_pm_qos_req’ undeclared (first use in this function)
143 | cpu_latency_qos_add_request(&woal_pcie_pm_qos_req, 0);
| ^~~~~~~~~~~~~~~~~~~~
/home/sherry/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_pcie.c:143:31: note: each undeclared identifier is reported only once for each function it appears in
/home/sherry/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_pcie.c: In function ‘woal_release_pmqos_busfreq_high’:
/home/sherry/work/mwifiex/mxm_wifiex/wlan_src/mlinux/moal_pcie.c:171:34: error: ‘woal_pcie_pm_qos_req’ undeclared (first use in this function)
171 | cpu_latency_qos_remove_request(&woal_pcie_pm_qos_req);
| ^~~~~~~~~~~~~~~~~~~~
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Reviewed-by: yang.tian <yang.tian@nxp.com>
