depau/Purism-Calls
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/calls.git synced 2025-01-09 05:15:31 +00:00
Code Issues Releases Wiki Activity

ofono-provider: Don't g_error() without good reason

Browse source 
Use g_warning() for things are not fatal.

Closes: #4
This commit is contained in:
Evangelos Ribeiro Tzaras 2022-09-02 13:11:19 +02:00
parent 1016505357
commit adb1cdb18a
1 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
plugins/provider/ofono/calls-ofono-provider.c
View file

@ -229,7 +229,7 @@ modem_proxy_new_cb (GDBusConnection *connection,
g_variant_unref (data->ifaces); g_variant_unref (data->ifaces);
g_free (data->name); g_free (data->name);
g_free (data); g_free (data);
g_error ("Error creating oFono Modem proxy: %s", g_warning ("Error creating oFono Modem proxy: %s",
error->message); error->message);
return; return;
} }
@ -423,8 +423,9 @@ ofono_appeared_cb (GDBusConnection *connection,
g_autoptr (GError) error = NULL; g_autoptr (GError) error = NULL;
self->connection = connection; self->connection = connection;
if (!self->connection) { if (!self->connection) {
g_error ("Error creating D-Bus connection: %s", g_warning ("Error creating D-Bus connection: %s",
error->message); error->message);
return;
} }
/* TODO this should be async */ /* TODO this should be async */
@ -436,8 +437,9 @@ ofono_appeared_cb (GDBusConnection *connection,
NULL, NULL,
&error); &error);
if (!self->manager) { if (!self->manager) {
g_error ("Error creating ModemManager object manager proxy: %s", g_warning ("Error creating ModemManager object manager proxy: %s",
error->message); error->message);
return;
} }
g_signal_connect (self->manager, "modem-added", g_signal_connect (self->manager, "modem-added",