From adb1cdb18a71a1f39b3838f79486047d726e2651 Mon Sep 17 00:00:00 2001 From: Evangelos Ribeiro Tzaras Date: Fri, 2 Sep 2022 13:11:19 +0200 Subject: [PATCH] ofono-provider: Don't g_error() without good reason Use g_warning() for things are not fatal. Closes: #4 --- plugins/provider/ofono/calls-ofono-provider.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/plugins/provider/ofono/calls-ofono-provider.c b/plugins/provider/ofono/calls-ofono-provider.c index ed93439..2370354 100644 --- a/plugins/provider/ofono/calls-ofono-provider.c +++ b/plugins/provider/ofono/calls-ofono-provider.c @@ -229,8 +229,8 @@ modem_proxy_new_cb (GDBusConnection *connection, g_variant_unref (data->ifaces); g_free (data->name); g_free (data); - g_error ("Error creating oFono Modem proxy: %s", - error->message); + g_warning ("Error creating oFono Modem proxy: %s", + error->message); return; } @@ -423,8 +423,9 @@ ofono_appeared_cb (GDBusConnection *connection, g_autoptr (GError) error = NULL; self->connection = connection; if (!self->connection) { - g_error ("Error creating D-Bus connection: %s", - error->message); + g_warning ("Error creating D-Bus connection: %s", + error->message); + return; } /* TODO this should be async */ @@ -436,8 +437,9 @@ ofono_appeared_cb (GDBusConnection *connection, NULL, &error); if (!self->manager) { - g_error ("Error creating ModemManager object manager proxy: %s", - error->message); + g_warning ("Error creating ModemManager object manager proxy: %s", + error->message); + return; } g_signal_connect (self->manager, "modem-added",