1
0
Fork 0
mirror of https://github.com/ytdl-org/youtube-dl.git synced 2024-11-25 19:52:11 +00:00
youtube-dl/youtube_dl
Yen Chi Hsuan 23495d6a39
Revert "[ffmpeg] Fix embedding subtitles (#9063)"
This reverts commit ccff2c404d.

Fixes #10081.

The new approach breaks embedding subtitles into video-only or
audio-only files. FFMpeg provides a trick: add '?' after the argument of
'-map' so that a missing stream is ignored. For example:

opts = [
    '-map', '0:v?',
    '-c:v', 'copy',
    '-map', '0:a?',
    '-c:a', 'copy',
    # other options...
]

Unfortunately, such a format is not implemented in avconv, either.
I guess adding '-ignore_unknown' if self.basename == 'ffmpeg' is the
best solution. However, the example mentioned in #9063 no longer serves
problematic files, so I can't test it. I'll reopen #9063 and wait for
another example so that I can test '-ignore_unknown'.
2016-07-15 20:02:36 +08:00
..
downloader
extractor [syfy] fix extraction(closes #9087)(closes #3820)(closes #2388) 2016-07-14 23:59:47 +01:00
postprocessor Revert "[ffmpeg] Fix embedding subtitles (#9063)" 2016-07-15 20:02:36 +08:00
__init__.py Rename --cn-verfication-proxy to --geo-verification-proxy 2016-07-03 23:29:56 +08:00
__main__.py
aes.py
cache.py
compat.py [compat] Fix test_cmdline_umlauts on Python 2.6 2016-07-07 22:30:58 +08:00
jsinterp.py
options.py [options] Rollback old behavior for configuratio files' encoding 2016-07-09 07:12:52 +07:00
socks.py
swfinterp.py
update.py
utils.py [brightcove] skip ism manifests 2016-07-14 14:13:57 +01:00
version.py release 2016.07.13 2016-07-13 23:58:01 +07:00
YoutubeDL.py Rename --cn-verfication-proxy to --geo-verification-proxy 2016-07-03 23:29:56 +08:00