depau/libfprint
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

synaptics: Delay verify operation completion until finger remoal

Browse source 
We used to return early in the case where the print matched in order to
report the result more quickly. However, with the early reporting
mechanism and the fprintd side implementation of it, this is not
necessary anymore.

As such, only stop the "verify" and "identify" operations when the
finger is removed (or the operation is cancelled, which is actually what
will happen currently).
This commit is contained in:
Benjamin Berg 2020-12-15 13:16:19 +01:00
parent 3d5db6a391
commit 35d2d78e67
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
libfprint/drivers/synaptics/synaptics.c
View file

@ -663,7 +663,7 @@ verify_msg_cb (FpiDeviceSynaptics *self,
fp_info ("Verify was successful! for user: %s finger: %d score: %f", fp_info ("Verify was successful! for user: %s finger: %d score: %f",
verify_resp->user_id, verify_resp->finger_id, verify_resp->match_result); verify_resp->user_id, verify_resp->finger_id, verify_resp->match_result);
fpi_device_verify_report (device, FPI_MATCH_SUCCESS, NULL, NULL); fpi_device_verify_report (device, FPI_MATCH_SUCCESS, NULL, NULL);
fpi_device_verify_complete (device, NULL); verify_complete_after_finger_removal (self);
break; break;
} }
} }
@ -789,17 +789,13 @@ identify_msg_cb (FpiDeviceSynaptics *self,
&index); &index);
if (found) if (found)
{
fpi_device_identify_report (device, g_ptr_array_index (prints, index), print, NULL); fpi_device_identify_report (device, g_ptr_array_index (prints, index), print, NULL);
fpi_device_identify_complete (device, NULL);
}
else else
{
fpi_device_identify_report (device, NULL, print, NULL); fpi_device_identify_report (device, NULL, print, NULL);
identify_complete_after_finger_removal (self); identify_complete_after_finger_removal (self);
} }
} }
}
} }
static void static void