From 0e351db91ab67130631f109f07f1ce7346f70ad7 Mon Sep 17 00:00:00 2001 From: Bastien Nocera Date: Fri, 25 May 2018 17:00:40 +0200 Subject: [PATCH] lib: Fix new BUG_ON() implementation again This time, the macro didn't wrap the condition, resulting in calls like BUG_ON(size > 100) being expanded to g_assert(!size > 100), when what we wanted was BUG_ON(!(size > 100)). See 9cca50165053084a151d7e69a7e82db98d46ed24, ff09456cf5adaead2d3993a7e1476e56a23ff7bb, and egg on my face. --- libfprint/fp_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libfprint/fp_internal.h b/libfprint/fp_internal.h index 446c7d1..3992dd1 100644 --- a/libfprint/fp_internal.h +++ b/libfprint/fp_internal.h @@ -47,7 +47,7 @@ #define fp_warn g_warning #define fp_err g_error -#define BUG_ON(condition) g_assert(!condition) +#define BUG_ON(condition) g_assert(!(condition)) #define BUG() g_assert_not_reached() enum fp_dev_state {