1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/calls.git synced 2024-06-28 14:49:30 +00:00
Purism-Calls/src/calls-call-record.c
Julian Sparber e911f391c6
Use correct parent class when chaining up overridden functions
How `g_type_class_peek ()` was used it didn't return the correct parent
class in most cases.
G_DEFINE_TYPE macro creates a pointer we can use to get the parent
class `n_p_parent_class`.
Because we didn't use the correct parent class the object initialisation
wasn't fully completed for some GtkWidgets.
See https://developer.gnome.org/gobject/stable/chapter-gobject.html#gobject-instantiation
for more information.

This commit makes use of the `n_p_parent_class pointer` created for this
specific use case where ever possible.

Fixes: https://source.puri.sm/Librem5/calls/issues/118
2020-02-19 12:49:58 +01:00

254 lines
6.2 KiB
C

/*
* Copyright (C) 2018, 2019 Purism SPC
*
* This file is part of Calls.
*
* Calls is free software: you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* Calls is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with Calls. If not, see <http://www.gnu.org/licenses/>.
*
* Author: Bob Ham <bob.ham@puri.sm>
*
* SPDX-License-Identifier: GPL-3.0-or-later
*
*/
#include "calls-call-record.h"
#include "util.h"
#include <glib/gi18n.h>
struct _CallsCallRecord
{
GomResource parent_instance;
guint id;
gchar *target;
gboolean inbound;
GDateTime *start;
GDateTime *answered;
GDateTime *end;
gboolean complete;
};
G_DEFINE_TYPE(CallsCallRecord, calls_call_record, GOM_TYPE_RESOURCE)
enum {
PROP_0,
PROP_ID,
PROP_TARGET,
PROP_INBOUND,
PROP_START,
PROP_ANSWERED,
PROP_END,
PROP_LAST_PROP,
};
static GParamSpec *props[PROP_LAST_PROP];
static void
get_property (GObject *object,
guint property_id,
GValue *value,
GParamSpec *pspec)
{
CallsCallRecord *self = CALLS_CALL_RECORD (object);
switch (property_id) {
#define case_set(prop,type,member) \
case PROP_##prop: \
g_value_set_##type (value, self->member); \
break;
case_set(ID, uint, id);
case_set(TARGET, string, target);
case_set(INBOUND, boolean, inbound);
case_set(START, boxed, start);
case_set(ANSWERED, boxed, answered);
case_set(END, boxed, end);
#undef case_set
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
break;
}
}
static void
set_date_time (GDateTime **stamp_ptr,
const GValue *value)
{
gpointer new_stamp = g_value_get_boxed (value);
g_clear_pointer (stamp_ptr, g_date_time_unref);
if (new_stamp)
{
*stamp_ptr = g_date_time_ref (new_stamp);
}
}
static void
set_property (GObject *object,
guint property_id,
const GValue *value,
GParamSpec *pspec)
{
CallsCallRecord *self = CALLS_CALL_RECORD (object);
switch (property_id) {
case PROP_ID:
self->id = g_value_get_uint (value);
break;
case PROP_TARGET:
CALLS_SET_PTR_PROPERTY (self->target, g_value_dup_string (value));
break;
case PROP_INBOUND:
self->inbound = g_value_get_boolean (value);
break;
case PROP_START:
set_date_time (&self->start, value);
break;
case PROP_ANSWERED:
set_date_time (&self->answered, value);
break;
case PROP_END:
set_date_time (&self->end, value);
break;
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
break;
}
}
static void
finalize (GObject *object)
{
CallsCallRecord *self = CALLS_CALL_RECORD (object);
g_clear_pointer (&self->end, g_date_time_unref);
g_clear_pointer (&self->answered, g_date_time_unref);
g_clear_pointer (&self->start, g_date_time_unref);
g_free (self->target);
G_OBJECT_CLASS (calls_call_record_parent_class)->finalize (object);
}
static void
calls_call_record_class_init (CallsCallRecordClass *klass)
{
GObjectClass *object_class = G_OBJECT_CLASS (klass);
GomResourceClass *resource_class = GOM_RESOURCE_CLASS (klass);
object_class->finalize = finalize;
object_class->get_property = get_property;
object_class->set_property = set_property;
gom_resource_class_set_table (resource_class, "calls");
#define install(NAME) \
g_object_class_install_property \
(object_class, PROP_##NAME, props[PROP_##NAME])
/*
* NB: ANY ADDITIONS TO THIS LIST REQUIRE AN INCREASE IN
* RECORD_STORE_VERSION IN calls-record-store.c AND THE USE OF
*
* gom_resource_class_set_property_new_in_version
* (resource_class, "property", 2);
*
* HERE.
*/
props[PROP_ID] =
g_param_spec_uint ("id",
_("ID"),
_("The row ID"),
0, G_MAXUINT, 0,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT);
install (ID);
gom_resource_class_set_primary_key (resource_class, "id");
props[PROP_TARGET] =
g_param_spec_string ("target",
_("Target"),
_("The PTSN phone number or other address of the call"),
NULL,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT);
install (TARGET);
props[PROP_INBOUND] =
g_param_spec_boolean ("inbound",
_("Inbound"),
_("Whether the call was an inbound call"),
FALSE,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT);
install (INBOUND);
props[PROP_START] =
g_param_spec_boxed ("start",
_("Start"),
_("Time stamp of the start of the call"),
G_TYPE_DATE_TIME,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT);
install (START);
props[PROP_ANSWERED] =
g_param_spec_boxed ("answered",
_("Answered"),
_("Time stamp of when the call was answered"),
G_TYPE_DATE_TIME,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT);
install (ANSWERED);
props[PROP_END] =
g_param_spec_boxed ("end",
_("End"),
_("Time stamp of the end of the call"),
G_TYPE_DATE_TIME,
G_PARAM_READWRITE | G_PARAM_CONSTRUCT);
install (END);
/*
* NB: ANY ADDITIONS TO THIS LIST REQUIRE AN INCREASE IN
* RECORD_STORE_VERSION IN calls-record-store.c AND THE USE OF
*
* gom_resource_class_set_property_new_in_version
* (resource_class, "property", 2);
*
* HERE.
*/
#undef install
}
static void
calls_call_record_init (CallsCallRecord *self)
{
}