mirror of
https://gitlab.gnome.org/GNOME/calls.git
synced 2024-11-18 01:25:35 +00:00
ddab47d288
The 'property-changed' and 'disconnect-reason' signals weren't disconnected on the voice_call object cleanup, and callbacks would thus still be fired once a second call happens, resulting in a crash. Signed-off-by: Eugenio Paolantonio (g7) <me@medesimo.eu>
444 lines
11 KiB
C
444 lines
11 KiB
C
/*
|
|
* Copyright (C) 2018 Purism SPC
|
|
*
|
|
* This file is part of Calls.
|
|
*
|
|
* Calls is free software: you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Calls is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Calls. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Author: Bob Ham <bob.ham@puri.sm>
|
|
*
|
|
* SPDX-License-Identifier: GPL-3.0-or-later
|
|
*
|
|
*/
|
|
|
|
#include "calls-ofono-call.h"
|
|
#include "calls-call.h"
|
|
#include "calls-message-source.h"
|
|
#include "util.h"
|
|
|
|
#include <glib/gi18n.h>
|
|
|
|
|
|
struct _CallsOfonoCall
|
|
{
|
|
GObject parent_instance;
|
|
GDBOVoiceCall *voice_call;
|
|
gchar *number;
|
|
gchar *name;
|
|
CallsCallState state;
|
|
gchar *disconnect_reason;
|
|
/* `inbound` is derived from `state` at construction time.
|
|
* If the call was already somehow accepted and thus state=active,
|
|
* then it's not possible to know the correct value for `inbound`. */
|
|
gboolean inbound;
|
|
};
|
|
|
|
static void calls_ofono_call_message_source_interface_init (CallsCallInterface *iface);
|
|
static void calls_ofono_call_call_interface_init (CallsCallInterface *iface);
|
|
|
|
G_DEFINE_TYPE_WITH_CODE (CallsOfonoCall, calls_ofono_call, G_TYPE_OBJECT,
|
|
G_IMPLEMENT_INTERFACE (CALLS_TYPE_MESSAGE_SOURCE,
|
|
calls_ofono_call_message_source_interface_init)
|
|
G_IMPLEMENT_INTERFACE (CALLS_TYPE_CALL,
|
|
calls_ofono_call_call_interface_init))
|
|
|
|
enum {
|
|
PROP_0,
|
|
PROP_VOICE_CALL,
|
|
PROP_PROPERTIES,
|
|
|
|
PROP_CALL_NUMBER,
|
|
PROP_CALL_INBOUND,
|
|
PROP_CALL_STATE,
|
|
PROP_CALL_NAME,
|
|
|
|
PROP_LAST_PROP,
|
|
};
|
|
static GParamSpec *props[PROP_LAST_PROP];
|
|
|
|
enum {
|
|
SIGNAL_TONE,
|
|
SIGNAL_LAST_SIGNAL,
|
|
};
|
|
static guint signals [SIGNAL_LAST_SIGNAL];
|
|
|
|
static void
|
|
change_state (CallsOfonoCall *self,
|
|
CallsCallState state)
|
|
{
|
|
CallsCallState old_state = self->state;
|
|
|
|
if (old_state == state)
|
|
{
|
|
return;
|
|
}
|
|
|
|
self->state = state;
|
|
g_object_notify_by_pspec (G_OBJECT (self), props[PROP_CALL_STATE]);
|
|
g_signal_emit_by_name (CALLS_CALL (self),
|
|
"state-changed",
|
|
state,
|
|
old_state);
|
|
}
|
|
|
|
|
|
struct CallsCallOperationData
|
|
{
|
|
const gchar *desc;
|
|
CallsOfonoCall *self;
|
|
gboolean (*finish_func) (GDBOVoiceCall *, GAsyncResult *, GError **);
|
|
};
|
|
|
|
|
|
static void
|
|
operation_cb (GDBOVoiceCall *voice_call,
|
|
GAsyncResult *res,
|
|
struct CallsCallOperationData *data)
|
|
{
|
|
gboolean ok;
|
|
GError *error = NULL;
|
|
|
|
ok = data->finish_func (voice_call, res, &error);
|
|
if (!ok)
|
|
{
|
|
g_warning ("Error %s oFono voice call to `%s': %s",
|
|
data->desc, data->self->number, error->message);
|
|
CALLS_ERROR (data->self, error);
|
|
}
|
|
|
|
g_free (data);
|
|
}
|
|
|
|
|
|
static void
|
|
answer (CallsCall *call)
|
|
{
|
|
CallsOfonoCall *self = CALLS_OFONO_CALL (call);
|
|
struct CallsCallOperationData *data;
|
|
|
|
data = g_new0 (struct CallsCallOperationData, 1);
|
|
data->desc = "answering";
|
|
data->self = self;
|
|
data->finish_func = gdbo_voice_call_call_answer_finish;
|
|
|
|
gdbo_voice_call_call_answer
|
|
(self->voice_call, NULL,
|
|
(GAsyncReadyCallback) operation_cb,
|
|
data);
|
|
}
|
|
|
|
|
|
static void
|
|
hang_up (CallsCall *call)
|
|
{
|
|
CallsOfonoCall *self = CALLS_OFONO_CALL (call);
|
|
struct CallsCallOperationData *data;
|
|
|
|
data = g_new0 (struct CallsCallOperationData, 1);
|
|
data->desc = "hanging up";
|
|
data->self = self;
|
|
data->finish_func = gdbo_voice_call_call_hangup_finish;
|
|
|
|
gdbo_voice_call_call_hangup
|
|
(self->voice_call, NULL,
|
|
(GAsyncReadyCallback) operation_cb,
|
|
data);
|
|
}
|
|
|
|
|
|
static void
|
|
tone_start (CallsCall *call, gchar key)
|
|
{
|
|
CallsOfonoCall *self = CALLS_OFONO_CALL (call);
|
|
if (self->state != CALLS_CALL_STATE_ACTIVE)
|
|
{
|
|
g_warning ("Tone start requested for non-active call to `%s'",
|
|
self->number);
|
|
return;
|
|
}
|
|
|
|
g_signal_emit_by_name (self, "tone", key);
|
|
}
|
|
|
|
|
|
static void
|
|
set_properties (CallsOfonoCall *self,
|
|
GVariant *props)
|
|
{
|
|
const gchar *str = NULL;
|
|
|
|
g_return_if_fail (props != NULL);
|
|
|
|
g_variant_lookup (props, "LineIdentification", "s", &self->number);
|
|
g_variant_lookup (props, "Name", "s", &self->name);
|
|
|
|
g_variant_lookup (props, "State", "&s", &str);
|
|
g_return_if_fail (str != NULL);
|
|
calls_call_state_parse_nick (&self->state, str);
|
|
|
|
if (self->state == CALLS_CALL_STATE_INCOMING)
|
|
{
|
|
self->inbound = TRUE;
|
|
}
|
|
}
|
|
|
|
|
|
static void
|
|
set_property (GObject *object,
|
|
guint property_id,
|
|
const GValue *value,
|
|
GParamSpec *pspec)
|
|
{
|
|
CallsOfonoCall *self = CALLS_OFONO_CALL (object);
|
|
|
|
switch (property_id) {
|
|
case PROP_VOICE_CALL:
|
|
g_set_object
|
|
(&self->voice_call, GDBO_VOICE_CALL (g_value_get_object (value)));
|
|
break;
|
|
|
|
case PROP_PROPERTIES:
|
|
set_properties (self, g_value_get_variant (value));
|
|
break;
|
|
|
|
default:
|
|
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
|
|
break;
|
|
}
|
|
}
|
|
|
|
static void
|
|
get_property (GObject *object,
|
|
guint property_id,
|
|
GValue *value,
|
|
GParamSpec *pspec)
|
|
{
|
|
CallsOfonoCall *self = CALLS_OFONO_CALL (object);
|
|
|
|
switch (property_id) {
|
|
case PROP_CALL_INBOUND:
|
|
g_value_set_boolean (value, self->state);
|
|
break;
|
|
|
|
case PROP_CALL_NAME:
|
|
g_value_set_string(value, self->name);
|
|
break;
|
|
|
|
case PROP_CALL_NUMBER:
|
|
g_value_set_string(value, self->number);
|
|
break;
|
|
|
|
case PROP_CALL_STATE:
|
|
g_value_set_enum (value, self->state);
|
|
break;
|
|
|
|
default:
|
|
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, property_id, pspec);
|
|
break;
|
|
}
|
|
}
|
|
|
|
static void
|
|
property_changed_cb (CallsOfonoCall *self,
|
|
const gchar *name,
|
|
GVariant *value)
|
|
{
|
|
GVariant *str_var;
|
|
gchar *str = NULL;
|
|
CallsCallState state;
|
|
gboolean ok;
|
|
|
|
{
|
|
gchar *text = g_variant_print (value, TRUE);
|
|
g_debug ("Property `%s' for oFono call to `%s' changed to: %s",
|
|
name, self->number, text);
|
|
g_free (text);
|
|
}
|
|
|
|
if (g_strcmp0 (name, "State") != 0)
|
|
{
|
|
return;
|
|
}
|
|
|
|
g_variant_get (value, "v", &str_var);
|
|
g_variant_get (str_var, "&s", &str);
|
|
g_return_if_fail (str != NULL);
|
|
|
|
ok = calls_call_state_parse_nick (&state, str);
|
|
if (ok)
|
|
{
|
|
change_state (self, state);
|
|
}
|
|
else
|
|
{
|
|
g_warning ("Could not parse new state `%s'"
|
|
" of oFono call to `%s'",
|
|
str, self->number);
|
|
}
|
|
|
|
g_variant_unref (str_var);
|
|
}
|
|
|
|
|
|
static void
|
|
disconnect_reason_cb (CallsOfonoCall *self,
|
|
const gchar *reason)
|
|
{
|
|
if (reason)
|
|
{
|
|
CALLS_SET_PTR_PROPERTY (self->disconnect_reason,
|
|
g_strdup (reason));
|
|
}
|
|
}
|
|
|
|
|
|
static void
|
|
constructed (GObject *object)
|
|
{
|
|
CallsOfonoCall *self = CALLS_OFONO_CALL (object);
|
|
|
|
g_return_if_fail (self->voice_call != NULL);
|
|
|
|
g_signal_connect_object (self->voice_call, "property-changed",
|
|
G_CALLBACK (property_changed_cb),
|
|
self, G_CONNECT_SWAPPED);
|
|
g_signal_connect_object (self->voice_call, "disconnect-reason",
|
|
G_CALLBACK (disconnect_reason_cb),
|
|
self, G_CONNECT_SWAPPED);
|
|
|
|
G_OBJECT_CLASS (calls_ofono_call_parent_class)->constructed (object);
|
|
}
|
|
|
|
|
|
static void
|
|
dispose (GObject *object)
|
|
{
|
|
CallsOfonoCall *self = CALLS_OFONO_CALL (object);
|
|
|
|
g_clear_object (&self->voice_call);
|
|
|
|
G_OBJECT_CLASS (calls_ofono_call_parent_class)->dispose (object);
|
|
}
|
|
|
|
|
|
static void
|
|
finalize (GObject *object)
|
|
{
|
|
CallsOfonoCall *self = CALLS_OFONO_CALL (object);
|
|
|
|
g_free (self->disconnect_reason);
|
|
g_free (self->name);
|
|
g_free (self->number);
|
|
|
|
G_OBJECT_CLASS (calls_ofono_call_parent_class)->finalize (object);
|
|
}
|
|
|
|
|
|
static void
|
|
calls_ofono_call_class_init (CallsOfonoCallClass *klass)
|
|
{
|
|
GObjectClass *object_class = G_OBJECT_CLASS (klass);
|
|
GType tone_arg_types = G_TYPE_CHAR;
|
|
|
|
object_class->set_property = set_property;
|
|
object_class->get_property = get_property;
|
|
object_class->constructed = constructed;
|
|
object_class->dispose = dispose;
|
|
object_class->finalize = finalize;
|
|
|
|
props[PROP_VOICE_CALL] =
|
|
g_param_spec_object ("voice-call",
|
|
"Voice call",
|
|
"A GDBO proxy object for the underlying call object",
|
|
GDBO_TYPE_VOICE_CALL,
|
|
G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY);
|
|
g_object_class_install_property (object_class, PROP_VOICE_CALL, props[PROP_VOICE_CALL]);
|
|
|
|
props[PROP_PROPERTIES] =
|
|
g_param_spec_variant ("properties",
|
|
"Properties",
|
|
"The a{sv} dictionary of properties for the voice call object",
|
|
G_VARIANT_TYPE_ARRAY,
|
|
NULL,
|
|
G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY);
|
|
g_object_class_install_property (object_class, PROP_PROPERTIES, props[PROP_PROPERTIES]);
|
|
|
|
#define IMPLEMENTS(ID, NAME) \
|
|
g_object_class_override_property (object_class, ID, NAME); \
|
|
props[ID] = g_object_class_find_property(object_class, NAME);
|
|
|
|
IMPLEMENTS(PROP_CALL_NUMBER, "number");
|
|
IMPLEMENTS(PROP_CALL_INBOUND, "inbound");
|
|
IMPLEMENTS(PROP_CALL_STATE, "state");
|
|
IMPLEMENTS(PROP_CALL_NAME, "name");
|
|
|
|
#undef IMPLEMENTS
|
|
|
|
signals[SIGNAL_TONE] =
|
|
g_signal_newv ("tone",
|
|
G_TYPE_FROM_CLASS (klass),
|
|
G_SIGNAL_RUN_LAST,
|
|
NULL, NULL, NULL, NULL,
|
|
G_TYPE_NONE,
|
|
1, &tone_arg_types);
|
|
}
|
|
|
|
|
|
static void
|
|
calls_ofono_call_message_source_interface_init (CallsCallInterface *iface)
|
|
{
|
|
}
|
|
|
|
|
|
static void
|
|
calls_ofono_call_call_interface_init (CallsCallInterface *iface)
|
|
{
|
|
iface->answer = answer;
|
|
iface->hang_up = hang_up;
|
|
iface->tone_start = tone_start;
|
|
}
|
|
|
|
|
|
static void
|
|
calls_ofono_call_init (CallsOfonoCall *self)
|
|
{
|
|
}
|
|
|
|
|
|
CallsOfonoCall *
|
|
calls_ofono_call_new (GDBOVoiceCall *voice_call,
|
|
GVariant *properties)
|
|
{
|
|
g_return_val_if_fail (GDBO_IS_VOICE_CALL (voice_call), NULL);
|
|
g_return_val_if_fail (properties != NULL, NULL);
|
|
|
|
return g_object_new (CALLS_TYPE_OFONO_CALL,
|
|
"voice-call", voice_call,
|
|
"properties", properties,
|
|
NULL);
|
|
}
|
|
|
|
|
|
const gchar *
|
|
calls_ofono_call_get_object_path (CallsOfonoCall *call)
|
|
{
|
|
return g_dbus_proxy_get_object_path (G_DBUS_PROXY (call->voice_call));
|
|
}
|
|
|
|
|
|
const gchar *
|
|
calls_ofono_call_get_disconnect_reason (CallsOfonoCall *call)
|
|
{
|
|
return call->disconnect_reason;
|
|
}
|