Evangelos Ribeiro Tzaras
18aea10ca3
manager: Remove unused key argument in g_hash_table_iter_next()
...
We're only interested in the value here.
2022-01-31 17:08:38 +00:00
Evangelos Ribeiro Tzaras
edbf046bfd
ui-call-data: Implement "active-time" property
2022-01-31 15:51:45 +01:00
Evangelos Ribeiro Tzaras
8543fc7ab5
Update libcallui subproject and adjust to CuiCallState changes
...
We already had our mapping between CallsCallStates and CuiCallStates in place,
but the _DIALING state got renamed to _CALLING.
Additionally bundle CallsCallStates that map to the same CuiCallState to remove
some code.
2022-01-31 15:25:46 +01:00
Evangelos Ribeiro Tzaras
ab3ff5772b
settings: Fix memory leak
...
g_settings_get_string() and g_settings_get_strv() are transfer full,
so we should use g_value_take_string() instead of g_value_set_string() and
g_value_take_boxed() instead of g_value_set_boxed()
2022-01-27 18:02:15 +01:00
Evangelos Ribeiro Tzaras
7587efb78a
log: Fix One Definition Rule
...
As caught by running with enabled address sanitization.
2022-01-27 18:02:15 +01:00
Evangelos Ribeiro Tzaras
1d1489e167
call: Fix memory leaks
2022-01-27 18:02:15 +01:00
Evangelos Ribeiro Tzaras
9569afa073
origin: Add transfer annotation for calls_origin_get_calls ()
2022-01-27 18:02:15 +01:00
Evangelos Ribeiro Tzaras
a7677798d1
dbus-manager: Fix critical when transforming call states
...
Fixes c796df9260
2022-01-26 08:27:31 +01:00
Evangelos Ribeiro Tzaras
656643c522
call: Temporarily hold ref while setting new state
...
This is needed to make sure the object stays alive, because some implementations
will unref the call after it has been set to a disconnected state.
This has become apparent because tests started failing when origins switched
from the "state-changed" to the "notify::state" signal (as is done in the next
commits).
2022-01-20 10:23:09 +00:00
Evangelos Ribeiro Tzaras
c594726ce5
best-match: Fix potential memory leak
...
We would leak memory if calls_best_match_set_phone_number would be called a
second time with a SIP address.
2022-01-20 10:23:09 +00:00
Evangelos Ribeiro Tzaras
ebc5e584bb
manager: Use ternary operator instead of if/else block
...
Less code is better code.
2022-01-20 10:23:09 +00:00
Evangelos Ribeiro Tzaras
f01c99c587
ui-call-data: Remove unused struct
2022-01-20 10:23:09 +00:00
Evangelos Ribeiro Tzaras
36c4f2b349
ui-call-data: Add license header
2022-01-20 10:23:09 +00:00
Evangelos Ribeiro Tzaras
6567b7cad7
call-selector-item: Codestyle
...
Move public functions to the bottom
2022-01-20 10:23:09 +00:00
Evangelos Ribeiro Tzaras
c0a67d2cce
contacts-provider: Remove static from action name string
...
There was no reason to have it static in the first place.
2022-01-20 10:23:09 +00:00
Evangelos Ribeiro Tzaras
99057452c5
dbus: Document interface in a way that gtk-doc can use
...
Fixes #394
2022-01-20 10:50:48 +01:00
Evangelos Ribeiro Tzaras
12ae596352
contacts-provider: Overhaul documentation
...
This commit describes what CallsContactsProvider is used for,
documents signals, properties and the public API.
2022-01-20 10:17:26 +01:00
Evangelos Ribeiro Tzaras
bcdb703ec3
origin: Remove unused parameter from docstring
2022-01-20 10:17:26 +01:00
Evangelos Ribeiro Tzaras
4dd4ba3be3
provider: Remove unused parameter from docstring
2022-01-20 10:17:26 +01:00
Evangelos Ribeiro Tzaras
52eebaad83
message-source: Fix typo
2022-01-20 10:17:26 +01:00
Evangelos Ribeiro Tzaras
c796df9260
dbus-manager: Use CuiCallStates instead of CallsCallStates
...
CallsCallStates are considered internal call states and do not map 1:1 to
CuiCallStates.
2022-01-20 07:42:08 +00:00
Evangelos Ribeiro Tzaras
e3afefcef2
ui-call-data: Add call state mapping to public API
...
This allows it to get used in the DBus manager in a GBindingTransformFunc
until to make sure we don't use emit deprecated values over DBus.
2022-01-20 07:42:08 +00:00
Evangelos Ribeiro Tzaras
4bc8e82ff6
ui-call-data: Don't use deprecated states in mapping
...
For the UI we don't distinguish between dialing and alerting or between
waiting and incoming.
2022-01-20 07:42:08 +00:00
Evangelos Ribeiro Tzaras
6e9fadbee2
dbus: document states
2022-01-20 07:42:08 +00:00
Evangelos Ribeiro Tzaras
54092e45d4
call: Fix typos in section docstring
2022-01-18 03:53:11 +00:00
Evangelos Ribeiro Tzaras
827594dc2e
record-row: Add context menu entry for adding a new contact
...
Fixes #157
2022-01-18 02:12:37 +00:00
Evangelos Ribeiro Tzaras
5588bd934a
contacts-provider: Add API to add new contacts
2022-01-18 02:12:37 +00:00
Evangelos Ribeiro Tzaras
c6d867cd72
contacts-provider: Add GDBusActionGroup to query if contacts can be added
...
As this requires a patched GNOME Contacts, we want to be able to query if the
necessary actions to add new contacts is available before trying to use it.
2022-01-18 02:12:37 +00:00
Evangelos Ribeiro Tzaras
56da32d1b6
contacts-provider: Remove unused config.h include
2022-01-18 02:12:37 +00:00
Evangelos Ribeiro Tzaras
8ad21b211c
contacts-provider: Codestyle
2022-01-18 02:12:37 +00:00
Evangelos Ribeiro Tzaras
bc4ed210b2
contacts-provider: Sort includes
2022-01-18 02:12:37 +00:00
Evangelos Ribeiro Tzaras
339093876c
manager: Propagate messages from account
...
Not all portions from the user interface are listening directly to messages from
accounts, so the manager should propagate them to allow the UI to pick them up.
Closes #340
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
cc8da717b1
account-overview: Reindent ui file
...
This was done to avoid the diff noise in the previous commit introducing
the in app notifications to the account overview.
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
2a9791a9a3
account-overview: Show notification on account message
...
Accounts implement the CallsMessageSource interface and emit messages when
there are state changes of which the user should be informed.
Closes #340
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
4cd3a0dcc3
account: Add message emission API
...
This can be used when wanting to show a human readable description in the UI
for example when the account state changes.
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
cdb6f90acc
account: Rework account states
...
Introduce a state-changed signal which also gives a reason for why the state
changed. This will allow the UI to give some meaningful feedback to the user.
Additionally we can get rid of a number of things that were not really states,
but rather reasons for why a state changed (f.e. authentication failures).
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
6d877fd9d3
manager: Implement message source interface
...
This allows the user interface to pick up messages by having them propagate
from the managed providers, origins, calls, etc.
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
6de5e9a54c
manager: Remove the "error" signal and adapt to changes
...
We can now use the message source interface to signal any feedback to the user.
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
d1b20bec39
message-source: Add API to emit message
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
e148930cc4
application: Sort includes alphabetically
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
6a3702dea3
manager: Clean up includes
...
The manager is not using the account providers anywhere.
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
8a6787d959
message-source: Get rid of unnecessary semicolon
...
Our .dir-locals.el makes Emacs understand that we don't need a semicolon after
the various G_* macros.
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
7d05508ace
message-source: Clean up includes
...
Include directly what's being used here.
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
3c32739369
message-source: Use pragma once instead of include guard
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
c6a8dcf140
util: Use pragma once instead of include guard
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
eab45610bd
manager: Codestyle
...
We use two empty lines between functions, unless they are documented with
docstrings in which case there is only one empty line.
2022-01-11 12:00:10 +00:00
Evangelos Ribeiro Tzaras
66224c9a48
origin: Get rid of "numeric-addresses" property
2021-12-26 17:45:12 +01:00
Evangelos Ribeiro Tzaras
6d031e2ab6
new-call-box: Decide if numeric input is needed based on the origins protocol
...
The numeric addresses property conveys no additional information.
By changing the logic here we can get rid of the "numeric-addresses" property
alltogether.
2021-12-26 17:45:12 +01:00
Evangelos Ribeiro Tzaras
7fe8a90d77
settings: Add GSetting for preferred audio codecs
2021-12-21 15:05:47 +01:00
Evangelos Ribeiro Tzaras
dc809e54e5
settings: Add docstring for autoload-plugins setter and getter
2021-12-21 15:05:47 +01:00