depau/Purism-Calls
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/calls.git synced 2024-11-19 01:51:46 +00:00
Code Issues Releases Wiki Activity
857 commits 11 branches 53 tags 4.8 MiB
Commit graph

125 commits

Author SHA1 Message Date
Evangelos Ribeiro Tzaras
2df221c94c sip: origin: Warn instead of asserting in update_nua() on nua stack 
Crashing the application is overkill in this case.
 2021-09-02 09:12:13 +02:00
Evangelos Ribeiro Tzaras
16897eebe6 sip: origin: Include transport parameter in NUTAG_URL and friends 
This makes sure all of the supported protocols have a chance of working.

Since nua_set_params does not update NUTAG_URL (carefully rechecking the docs
verifies this), it is safe to remove the code in update_nua().

However, this means that we will have to recreate the nua stack,
which incidentally is currently being worked on:
https://gitlab.gnome.org/GNOME/calls/-/merge_requests/402
 2021-09-02 09:12:13 +02:00
Evangelos Ribeiro Tzaras
7330fe11fd account-widget: Fix apply button not becoming sensitive 
when only the transport protocol has been changed.
 2021-09-02 09:12:13 +02:00
Evangelos Ribeiro Tzaras
42c0872499 origin: Fix the password when updating credentials 
Updating the credentials was broken otherwise.
 2021-09-02 09:12:13 +02:00
Evangelos Ribeiro Tzaras
0bfa55473e sip: Make save_to_disk() public and use it when updating accounts 
Account credentials will not get updated at all otherwise.
 2021-09-02 09:12:13 +02:00
Evangelos Ribeiro Tzaras
f47139f7d2 account-widget: Actually use the entered port 2021-09-02 09:12:13 +02:00
Evangelos Ribeiro Tzaras
9faac7e789 account-widget: Actually use the selected protocol 
instead of using the hardcoded UDP value.
 2021-09-02 09:12:13 +02:00
Evangelos Ribeiro Tzaras
5371debc57 sip: origin: Bail when trying to go online but nua handle is not present 
This fixes a segmentation fault.
 2021-09-02 09:12:13 +02:00
Evangelos Ribeiro Tzaras
c9dd476fa8 sip: Avoid dereferencing a NULL pointer 
secret_password_*_finish() may return FALSE without setting the GError.
F.e. trying to remove a non existent secret is not a failure.

The bug supposedly manifests itself because the updating account credentials
from the UI does not always seem to work correctly.
 2021-08-26 12:04:21 +00:00
Evangelos Ribeiro Tzaras
77ec258acc sip: provider: Try to create folder for credentials 
Otherwise the user could be left unable to save credentials to disk later.

Fixes #326
 2021-08-26 12:23:20 +02:00
Evangelos Ribeiro Tzaras
4e76efc5e7 sip: provider: No need to print warning when no credentials file found 
The file could simply not (yet) exist.
 2021-08-26 12:23:20 +02:00
Evangelos Ribeiro Tzaras
2520a9a555 sip: Avoid g_error for non-fatal issues 
The media pipeline acting up does not warrant crashing the application.
 2021-08-26 12:23:19 +02:00
Evangelos Ribeiro Tzaras
c7731b189a origin: Add "numeric-addresses" property 
This will be useful in the dialpad to determine whether we should allow
only numeric input or not.
 2021-08-13 02:13:27 +02:00
Evangelos Ribeiro Tzaras
f5cd48bd99 sip: origin: Add protocol prefix if missing 2021-08-13 02:13:27 +02:00
Mohammed Sadiq
55a69944f1 sip-account-widget: Validate port value on change 2021-08-10 14:03:13 +00:00
Evangelos Ribeiro Tzaras
21578557f4 sip: provider: Don't store the password in the GKeyFile 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
fe6b5f9f4a sip: provider: Retrieve password from keyring 
Fixes #251.
 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
8ca63828df sip: provider: Delete password from keyring when deleting account 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
a8516f6e7b sip: provider: Update credentials on disk when removing origin 
Otherwise the key file will be unaltered and loads the same account on
the next startup.

One more step closer to fixing #251.
 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
40cea6760b sip: provider: Use the secret store to store credentials 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
3f12b3fcd5 sip: provider: Add argument to _add_origin() whether to store credentials 
This allows us to avoid unnecessary saving to disk during initial account
loading.
 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
e9f155678e sip: origin: Set and update name of origin 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
5c1b76908b sip: provider: Save accounts to disk 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
7717633698 sip: provider: Add API to save credentials to GKeyFile 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
0e5366ddbb sip: account-widget: Emit "widget-edit-done" when done editting 
This let's top level containers know to take appropriate action (i.e. hide).
 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
e36469e796 sip: Implement CallsAccountProvider interface 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
23cb050f61 sip: Introduce CallsSipAccountWidget 
This widget can be used to add new accounts or edit existing ones.

First part of #264.
 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
1749dcec60 sip: provider: Add API to remove origins 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
1a4b501653 sip: provider: Rename test environment variable 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
fd9b57c1b3 sip: provider: Load credentials from GKeyFile 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
58331afcf7 sip: provider: Use g_auto and GStrv 
Instead of char** and g_strfreev()
 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
a638b64402 account: Add address property 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
babd013bd7 Remove CallsCredentials and adapt to changes 
The provider knows best which credentials it needs and CallsCredentials
was not generic to begin with, so get rid of it.
 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
2af2b316ec Various codestyle fixes 2021-07-20 10:17:17 +02:00
Evangelos Ribeiro Tzaras
864a15d799 sip: origin: Explicitly include contact header for sofia > 1.13 
Fixes #304
 2021-07-16 09:11:27 +00:00
Evangelos Ribeiro Tzaras
f930874d00 sip: provider: Keep provider alive while there are still origins 
CallsSipOrigin accesses the CallsSipContext (owned by the provider) in its
dispose() which will be invalid once CallsSipProvider gets freed.
This commit will make certain that the provider stays alive for the lifetime
of it's origins.
 2021-06-26 08:56:18 +02:00
Evangelos Ribeiro Tzaras
8a230fc5b5 sip: origin: No need to explicitly clear nua handles 
Memory allocations from su_home_t will get cleaned up, when the home is freed.
 2021-06-21 13:20:32 +02:00
Evangelos Ribeiro Tzaras
a803294c4a sip: origin: Handle unregistering (going offline) 
and set the account state accordingly.
 2021-06-18 19:29:25 +02:00
Evangelos Ribeiro Tzaras
e6c7994abc sip: origin: Remove unnecessary notify 2021-06-18 19:29:25 +02:00
Evangelos Ribeiro Tzaras
5bd84043b9 sip: origin: codestyle 2021-06-18 19:28:12 +02:00
Evangelos Ribeiro Tzaras
dbb829be06 debug: Add G_LOG_DOMAIN to every file using g_debug() 2021-06-18 11:12:13 +02:00
Evangelos Ribeiro Tzaras
736c17a4bc sip: origin: Fix if condition in dispose() 
This should make sure that origins go offline
 2021-06-11 17:51:06 +02:00
Evangelos Ribeiro Tzaras
7988ddf85b sip: media-pipeline: Don't shadow props variable 
As caught by compiling with `-Wshadow`
 2021-06-03 19:46:45 +00:00
Evangelos Ribeiro Tzaras
2847508034 Fix missing-declarations warnings all over the codebase 
As caught by compiling with `-Wmissing-declarations`
by either making functions static, or declaring them in the header.
 2021-06-03 19:46:45 +00:00
Evangelos Ribeiro Tzaras
96a7d901c1 Fix old-style warnings all over the codebase 
As caught by compiling with `-Wold-style-definition` and `-Wstrict-prototypes`.
 2021-06-03 19:46:45 +00:00
Evangelos Ribeiro Tzaras
dde4bd8abf sip: provider: Don't warn when trying to add account multiple times 
A g_debug() will suffice which will let us get rid of g_test_expect_message() to
as we don't need to guard against the warning anymore.
 2021-06-01 14:52:23 +02:00
Evangelos Ribeiro Tzaras
0c966fdf83 origin: Add API to query supported protocols 
This will allow selecting a suitable origin when placing outgoing calls.
 2021-05-28 17:02:02 +02:00
Evangelos Ribeiro Tzaras
7ad0f4cdd6 provider: Add API to query supported protocols 
These are the protocols that the provider plugin may support. The origins
must be queried independently whether or not they support any given protocol.

Example: A SIP origin/account may or may not support the "tel" protocol.
 2021-05-28 17:02:02 +02:00
Evangelos Ribeiro Tzaras
53f69b06dd call: Introduce protocol property 2021-05-28 13:18:24 +02:00
Evangelos Ribeiro Tzaras
1def4c3585 plugins: provider: Use CallsOrigin instead of derived types for GListStore 
Otherwise we run into trouble when using `g_list_store_find()`
 2021-05-28 13:18:24 +02:00