tests: Don't mock calls_contacts_provider_new()

Having set which folks backends to use the real function can be used
without causing any warnings leading to the build to fail.

tests/meson.build

@@ -23,16 +23,12 @@ test_link_args = [
   '-fPIC',
 ]
 
-mock_link_args = [ test_link_args,
-                   '-Wl,--wrap=calls_contacts_provider_new',
-                 ]
-
 
 test_sources = [ 'test-manager.c' ]
 
 t = executable('manager', test_sources,
                  c_args : test_cflags,
-                 link_args: mock_link_args,
+                 link_args: test_link_args,
                  pie: true,
                  link_with : [calls_vala, libcalls],
                  dependencies: calls_deps,
@@ -73,7 +69,7 @@ test('util', t, env: test_env)
 test_sources = [ 'test-ui-call.c', 'mock-call.c', 'mock-call.h' ]
 t = executable('ui-call', test_sources,
                c_args : test_cflags,
-               link_args : mock_link_args,
+               link_args : test_link_args,
                pie: true,
                link_with : [calls_vala, libcalls],
                dependencies : calls_deps,
@@ -90,7 +86,7 @@ test_sources = [
 
 t = executable('ringer', test_sources,
                c_args : test_cflags,
-               link_args: mock_link_args,
+               link_args: test_link_args,
                pie: true,
                link_with : [calls_vala, libcalls, libfeedback],
                dependencies: calls_deps,

tests/mock-contacts-provider.h

@@ -1,14 +0,0 @@
-/*
- * Copyright (C) 2021 Purism SPC
- *
- * SPDX-License-Identifier: GPL-3.0-or-later
- *
- * Author: Evangelos Ribeiro Tzaras <devrtz@fortysixandtwo.eu>
- *
- */
-
-#pragma once
-
-#include "calls-contacts-provider.h"
-
-CallsContactsProvider *__wrap_calls_contacts_provider_new (void);

tests/test-manager.c

@@ -5,18 +5,11 @@
  */
 
 #include "calls-manager.h"
-#include "mock-contacts-provider.h"
 
 #include <cui-call.h>
 #include <gtk/gtk.h>
 #include <libpeas/peas.h>
 
-CallsContactsProvider *
-__wrap_calls_contacts_provider_new (void)
-{
-  return NULL;
-}
-
 struct TestData {
   GMainLoop *loop;
   CallsManager *manager;

tests/test-ringer.c

@@ -11,15 +11,6 @@
 #include "calls-ringer.h"
 #include "calls-ui-call-data.h"
 #include "mock-call.h"
-#include "mock-contacts-provider.h"
-
-
-/* mock calls_contacts_provider_new() */
-CallsContactsProvider *
-__wrap_calls_contacts_provider_new (void)
-{
-  return NULL;
-}
 
 
 /* add or remove calls */

tests/test-ui-call.c

@@ -9,17 +9,9 @@
 
 #include "calls-ui-call-data.h"
 #include "mock-call.h"
-#include "mock-contacts-provider.h"
 
 #include <gtk/gtk.h>
 
-CallsContactsProvider *
-__wrap_calls_contacts_provider_new (void)
-{
-  return NULL;
-}
-
-
 static void
 test_cui_call_state_mapping (void)
 {