depau/Purism-Calls
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/calls.git synced 2024-11-17 07:46:03 +00:00
Code Issues Releases Wiki Activity

ringer: Break loop if triggered event was ended immediately

Browse source 
When the only feedback of an event is unavailable on a system (e.g. no
vibration motor or LED) the "feedback-ended" signal is emitted
immediately and the end reason will be LFB_EVENT_END_REASON_NOT_FOUND.

In this case we need to change the target state, so that our logic does
not end up retriggering the event infinitely.
This commit is contained in:
Evangelos Ribeiro Tzaras 2022-11-04 09:48:41 +01:00
parent e52f327aae
commit e1f0b83d25
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/calls-ringer.c
View file

@ -198,6 +198,12 @@ on_feedback_ended (LfbEvent *event,
return; return;
} }
/* When no feedback is available on the system (e.g. no vibration motor or LEDs)
* it will get ended immediately on triggering. Changing the target state will
* break loop that would otherwise occur. */
if (lfb_event_get_end_reason (event) == LFB_EVENT_END_REASON_NOT_FOUND)
self->target_state = CALLS_RING_STATE_INACTIVE;
set_ring_state (self, CALLS_RING_STATE_INACTIVE); set_ring_state (self, CALLS_RING_STATE_INACTIVE);
} }