depau/Purism-Calls
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/calls.git synced 2025-01-07 12:25:31 +00:00
Code Issues Releases Wiki Activity

sip: Avoid g_error for non-fatal issues

Browse source 
The media pipeline acting up does not warrant crashing the application.
This commit is contained in:
Evangelos Ribeiro Tzaras 2021-08-25 20:36:01 +02:00
parent 2336c973a1
commit 2520a9a555
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
plugins/sip/calls-sip-media-pipeline.c
View file

@ -121,7 +121,7 @@ on_pad_added (GstElement *rtpbin,
sinkpad = gst_element_get_static_pad (depayloader, "sink"); sinkpad = gst_element_get_static_pad (depayloader, "sink");
if (gst_pad_link (srcpad, sinkpad) != GST_PAD_LINK_OK) if (gst_pad_link (srcpad, sinkpad) != GST_PAD_LINK_OK)
g_error ("Failed to link rtpbin to depayloader"); g_warning ("Failed to link rtpbin to depayloader");
gst_object_unref (sinkpad); gst_object_unref (sinkpad);
} }
@ -141,7 +141,7 @@ on_bus_message (GstBus *bus,
g_autofree char *msg = NULL; g_autofree char *msg = NULL;
gst_message_parse_error (message, &error, &msg); gst_message_parse_error (message, &error, &msg);
g_error ("Error: %s", msg); g_warning ("Error on the message bus: %s (%s)", error->message, msg);
break; break;
} }
@ -151,7 +151,7 @@ on_bus_message (GstBus *bus,
g_autofree char *msg = NULL; g_autofree char *msg = NULL;
gst_message_parse_warning (message, &error, &msg); gst_message_parse_warning (message, &error, &msg);
g_warning ("Warning: %s", msg); g_warning ("Warning on the message bus: %s (%s)", error->message, msg);
break; break;
} }
@ -680,7 +680,7 @@ calls_sip_media_pipeline_new (MediaCodecInfo *codec)
"codec", codec, "codec", codec,
NULL); NULL);
if (pipeline == NULL) if (pipeline == NULL)
g_error ("Media pipeline could not be initialized: %s", error->message); g_warning ("Media pipeline could not be initialized: %s", error->message);
return pipeline; return pipeline;
} }

2
plugins/sip/calls-sip-provider.c
View file

@ -375,7 +375,7 @@ calls_sip_provider_deinit_sip (CallsSipProvider *self)
su_root_destroy (self->ctx->root); su_root_destroy (self->ctx->root);
if (su_home_unref (self->ctx->home) != 1) if (su_home_unref (self->ctx->home) != 1)
g_error ("Error in su_home_unref ()"); g_warning ("Error in su_home_unref ()");
} }
g_clear_pointer (&self->ctx, g_free); g_clear_pointer (&self->ctx, g_free);