depau/Purism-Calls
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/calls.git synced 2024-11-16 05:15:36 +00:00
Code Issues Releases Wiki Activity
Purism-Calls/tests/test-manager.c

275 lines
8.8 KiB
C
Raw Normal View History

Manager: add test
2020-03-20 17:33:59 +00:00
/*
* Copyright (C) 2020 Purism SPC
*
* SPDX-License-Identifier: GPL-3.0+
*/
#include "calls-manager.h"
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
#include "mock-contacts-provider.h"
Manager: add test
2020-03-20 17:33:59 +00:00
tests: manager: Switch to CallsUiCallData
2022-01-31 16:07:41 +00:00
#include <cui-call.h>
Manager: add test
2020-03-20 17:33:59 +00:00
#include <gtk/gtk.h>
#include <libpeas/peas.h>
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
CallsContactsProvider *
settings: Convert to the singleton pattern We only have a single source of settings, so we should reflect that by using a singleton. This also reduces our LoC. This doesn't impair our ability to run tests because there we run with GSETTINGS_BACKEND=memory
2022-05-09 20:57:41 +00:00
__wrap_calls_contacts_provider_new (void)
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
{
return NULL;
}
struct TestData {
GMainLoop *loop;
CallsManager *manager;
GListModel *origins;
GListModel *origins_tel;
CallsOrigin *origin;
CuiCall *call;
};
Manager: add test
2020-03-20 17:33:59 +00:00
static void
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
call_add_cb (CallsManager *manager,
CuiCall *call,
struct TestData *data)
Manager: add test
2020-03-20 17:33:59 +00:00
{
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
static guint phase = 0;
data->call = call;
switch (phase++) {
case 0:
cui_call_hang_up (call);
break;
case 1:
/* Unload the provider */
calls_manager_remove_provider (data->manager, "dummy");
g_assert_false (calls_manager_has_provider (data->manager, "dummy"));
g_assert_false (calls_manager_has_any_provider (data->manager));
break;
default:
g_assert_not_reached ();
}
Manager: add test
2020-03-20 17:33:59 +00:00
}
static void
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
call_remove_cb (CallsManager *manager,
CuiCall *call,
struct TestData *data)
Manager: add test
2020-03-20 17:33:59 +00:00
{
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
static guint phase = 0;
g_assert_true (call == data->call);
data->call = NULL;
switch (phase++) {
case 0:
/* Add new call do check if we remove it when we unload the provider */
calls_origin_dial (data->origin, "+393422342");
break;
case 1:
g_main_loop_quit (data->loop);
break;
default:
g_assert_not_reached ();
}
Manager: add test
2020-03-20 17:33:59 +00:00
}
static void
Fix old-style warnings all over the codebase As caught by compiling with `-Wold-style-definition` and `-Wstrict-prototypes`.
2021-06-02 18:18:50 +00:00
test_calls_manager_without_provider (void)
Manager: add test
2020-03-20 17:33:59 +00:00
{
manager: support multiple providers This includes the following changes: - Introduce a `providers` hash table to keep track of multiple CallProvider's and remove the `provider` member - Remove `calls_manager_get_provider()` and `calls_manager_set_provider()` in favour of `calls_manager_add_provider()`, `calls_manager_remove_provider()` and `calls_manager_has_provider()` - Introduce a `origins` GListStore to keep track of available origins. `origins` is updated in `items_changed_cb()` when the origins of any CallsProvider are updated. - Adapt to changes with respect to `calls_manager_get_origins()`. - Introduce `origins_by_protocol` hash table to keep track of available origins per protocol. - Adjust tests - We temporarily break country code lookup which was handled previously with the "default-origin" mechanism. We will add it back to the CallsSettings class which will provide a better application-wide mechanism.
2021-04-13 09:36:58 +00:00
guint no_origins;
GListModel *origins;
Manager: add test
2020-03-20 17:33:59 +00:00
g_autoptr (CallsManager) manager = calls_manager_new ();
test: manager: Use more appropriate `g_assert_*()` calls
2021-05-05 15:19:24 +00:00
g_assert_true (CALLS_IS_MANAGER (manager));
Manager: add test
2020-03-20 17:33:59 +00:00
manager: Use state flags instead of an enum and adapt to changes This gives us some more granularity and is overall a better fit than the states previously used. Closes #327
2022-01-26 13:18:24 +00:00
g_assert_cmpuint (calls_manager_get_state_flags (manager), ==, CALLS_MANAGER_FLAGS_UNKNOWN);
manager: support multiple providers This includes the following changes: - Introduce a `providers` hash table to keep track of multiple CallProvider's and remove the `provider` member - Remove `calls_manager_get_provider()` and `calls_manager_set_provider()` in favour of `calls_manager_add_provider()`, `calls_manager_remove_provider()` and `calls_manager_has_provider()` - Introduce a `origins` GListStore to keep track of available origins. `origins` is updated in `items_changed_cb()` when the origins of any CallsProvider are updated. - Adapt to changes with respect to `calls_manager_get_origins()`. - Introduce `origins_by_protocol` hash table to keep track of available origins per protocol. - Adjust tests - We temporarily break country code lookup which was handled previously with the "default-origin" mechanism. We will add it back to the CallsSettings class which will provide a better application-wide mechanism.
2021-04-13 09:36:58 +00:00
origins = calls_manager_get_origins (manager);
no_origins = g_list_model_get_n_items (origins);
g_assert_cmpuint (no_origins, ==, 0);
Manager: add test
2020-03-20 17:33:59 +00:00
g_assert_null (calls_manager_get_calls (manager));
test: manager: Expanded *has_provider() testing
2021-05-19 22:54:40 +00:00
g_assert_false (calls_manager_has_any_provider (manager));
manager: Hardcode supported protocols and adapt to changes This simplifies the code quite a bit by removing the supported protocols from being determined dynamically via the loaded plugins. It was previously used to add/remove a GListStore to origins_by_protocol. This is a prerequisite for having per protocol dial actions.
2022-01-26 07:24:09 +00:00
origins = calls_manager_get_suitable_origins (manager, "tel:+123456789");
g_assert_cmpuint (g_list_model_get_n_items (origins), ==, 0);
origins = calls_manager_get_suitable_origins (manager, "sip:alice@example.org");
g_assert_cmpuint (g_list_model_get_n_items (origins), ==, 0);
origins = calls_manager_get_suitable_origins (manager, "sips:bob@example.org");
g_assert_cmpuint (g_list_model_get_n_items (origins), ==, 0);
Manager: add test
2020-03-20 17:33:59 +00:00
}
static void
Fix old-style warnings all over the codebase As caught by compiling with `-Wold-style-definition` and `-Wstrict-prototypes`.
2021-06-02 18:18:50 +00:00
test_calls_manager_dummy_provider (void)
Manager: add test
2020-03-20 17:33:59 +00:00
{
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
CallsManager *manager;
provider: Use GListModel to track origins And adapt to changes It's easier to track changes if we are using GListModel than a GList. Also, eventually we shall have multiple providers, and we can use GtkFlattenListModel to merge multiple origins without manually managing pointers ourself. Since several widgets has APIs to handle GListModels, it will also help us create widgets from GListModels easily.
2021-02-15 05:34:34 +00:00
GListModel *origins;
manager: support multiple providers This includes the following changes: - Introduce a `providers` hash table to keep track of multiple CallProvider's and remove the `provider` member - Remove `calls_manager_get_provider()` and `calls_manager_set_provider()` in favour of `calls_manager_add_provider()`, `calls_manager_remove_provider()` and `calls_manager_has_provider()` - Introduce a `origins` GListStore to keep track of available origins. `origins` is updated in `items_changed_cb()` when the origins of any CallsProvider are updated. - Adapt to changes with respect to `calls_manager_get_origins()`. - Introduce `origins_by_protocol` hash table to keep track of available origins per protocol. - Adjust tests - We temporarily break country code lookup which was handled previously with the "default-origin" mechanism. We will add it back to the CallsSettings class which will provide a better application-wide mechanism.
2021-04-13 09:36:58 +00:00
GListModel *origins_tel;
guint position;
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
struct TestData *test_data;
Manager: add test
2020-03-20 17:33:59 +00:00
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
test_data = g_new0 (struct TestData, 1);
test_data->manager = calls_manager_new ();
manager = test_data->manager;
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
g_assert_true (CALLS_IS_MANAGER (manager));
manager: Use state flags instead of an enum and adapt to changes This gives us some more granularity and is overall a better fit than the states previously used. Closes #327
2022-01-26 13:18:24 +00:00
g_assert_cmpuint (calls_manager_get_state_flags (manager), ==, CALLS_MANAGER_FLAGS_UNKNOWN);
Manager: add test
2020-03-20 17:33:59 +00:00
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
test_data->origins = calls_manager_get_origins (manager);
origins = test_data->origins;
manager: support multiple providers This includes the following changes: - Introduce a `providers` hash table to keep track of multiple CallProvider's and remove the `provider` member - Remove `calls_manager_get_provider()` and `calls_manager_set_provider()` in favour of `calls_manager_add_provider()`, `calls_manager_remove_provider()` and `calls_manager_has_provider()` - Introduce a `origins` GListStore to keep track of available origins. `origins` is updated in `items_changed_cb()` when the origins of any CallsProvider are updated. - Adapt to changes with respect to `calls_manager_get_origins()`. - Introduce `origins_by_protocol` hash table to keep track of available origins per protocol. - Adjust tests - We temporarily break country code lookup which was handled previously with the "default-origin" mechanism. We will add it back to the CallsSettings class which will provide a better application-wide mechanism.
2021-04-13 09:36:58 +00:00
g_assert_true (origins);
g_assert_cmpuint (g_list_model_get_n_items (origins), ==, 0);
calls_manager_add_provider (manager, "dummy");
test: manager: Expanded *has_provider() testing
2021-05-19 22:54:40 +00:00
g_assert_true (calls_manager_has_any_provider (manager));
manager: support multiple providers This includes the following changes: - Introduce a `providers` hash table to keep track of multiple CallProvider's and remove the `provider` member - Remove `calls_manager_get_provider()` and `calls_manager_set_provider()` in favour of `calls_manager_add_provider()`, `calls_manager_remove_provider()` and `calls_manager_has_provider()` - Introduce a `origins` GListStore to keep track of available origins. `origins` is updated in `items_changed_cb()` when the origins of any CallsProvider are updated. - Adapt to changes with respect to `calls_manager_get_origins()`. - Introduce `origins_by_protocol` hash table to keep track of available origins per protocol. - Adjust tests - We temporarily break country code lookup which was handled previously with the "default-origin" mechanism. We will add it back to the CallsSettings class which will provide a better application-wide mechanism.
2021-04-13 09:36:58 +00:00
g_assert_true (calls_manager_has_provider (manager, "dummy"));
manager: Use state flags instead of an enum and adapt to changes This gives us some more granularity and is overall a better fit than the states previously used. Closes #327
2022-01-26 13:18:24 +00:00
/* Dummy plugin fakes being a modem */
g_assert_cmpuint (calls_manager_get_state_flags (manager), ==,
CALLS_MANAGER_FLAGS_HAS_CELLULAR_PROVIDER |
CALLS_MANAGER_FLAGS_HAS_CELLULAR_MODEM);
Manager: add test
2020-03-20 17:33:59 +00:00
manager: support multiple providers This includes the following changes: - Introduce a `providers` hash table to keep track of multiple CallProvider's and remove the `provider` member - Remove `calls_manager_get_provider()` and `calls_manager_set_provider()` in favour of `calls_manager_add_provider()`, `calls_manager_remove_provider()` and `calls_manager_has_provider()` - Introduce a `origins` GListStore to keep track of available origins. `origins` is updated in `items_changed_cb()` when the origins of any CallsProvider are updated. - Adapt to changes with respect to `calls_manager_get_origins()`. - Introduce `origins_by_protocol` hash table to keep track of available origins per protocol. - Adjust tests - We temporarily break country code lookup which was handled previously with the "default-origin" mechanism. We will add it back to the CallsSettings class which will provide a better application-wide mechanism.
2021-04-13 09:36:58 +00:00
g_assert_cmpuint (g_list_model_get_n_items (origins), >, 0);
Manager: add test
2020-03-20 17:33:59 +00:00
g_assert_null (calls_manager_get_calls (manager));
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
test_data->origin = g_list_model_get_item (origins, 0);
g_assert_true (CALLS_IS_ORIGIN (test_data->origin));
Manager: add test
2020-03-20 17:33:59 +00:00
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
test_data->origins_tel = calls_manager_get_suitable_origins (manager, "tel:+393422342");
origins_tel = test_data->origins_tel;
manager: support multiple providers This includes the following changes: - Introduce a `providers` hash table to keep track of multiple CallProvider's and remove the `provider` member - Remove `calls_manager_get_provider()` and `calls_manager_set_provider()` in favour of `calls_manager_add_provider()`, `calls_manager_remove_provider()` and `calls_manager_has_provider()` - Introduce a `origins` GListStore to keep track of available origins. `origins` is updated in `items_changed_cb()` when the origins of any CallsProvider are updated. - Adapt to changes with respect to `calls_manager_get_origins()`. - Introduce `origins_by_protocol` hash table to keep track of available origins per protocol. - Adjust tests - We temporarily break country code lookup which was handled previously with the "default-origin" mechanism. We will add it back to the CallsSettings class which will provide a better application-wide mechanism.
2021-04-13 09:36:58 +00:00
g_assert_true (G_IS_LIST_MODEL (origins_tel));
g_assert_true (G_IS_LIST_STORE (origins_tel));
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
g_assert_true (g_list_store_find (G_LIST_STORE (origins_tel), test_data->origin, &position));
Manager: add test
2020-03-20 17:33:59 +00:00
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
g_signal_connect (manager, "ui-call-added", G_CALLBACK (call_add_cb), test_data);
g_signal_connect (manager, "ui-call-removed", G_CALLBACK (call_remove_cb), test_data);
Manager: add test
2020-03-20 17:33:59 +00:00
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
calls_origin_dial (test_data->origin, "+393422343");
g_assert_true (CUI_IS_CALL (test_data->call));
Manager: add test
2020-03-20 17:33:59 +00:00
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
test_data->loop = g_main_loop_new (NULL, FALSE);
g_main_loop_run (test_data->loop);
g_main_loop_unref (test_data->loop);
Manager: add test
2020-03-20 17:33:59 +00:00
manager: support multiple providers This includes the following changes: - Introduce a `providers` hash table to keep track of multiple CallProvider's and remove the `provider` member - Remove `calls_manager_get_provider()` and `calls_manager_set_provider()` in favour of `calls_manager_add_provider()`, `calls_manager_remove_provider()` and `calls_manager_has_provider()` - Introduce a `origins` GListStore to keep track of available origins. `origins` is updated in `items_changed_cb()` when the origins of any CallsProvider are updated. - Adapt to changes with respect to `calls_manager_get_origins()`. - Introduce `origins_by_protocol` hash table to keep track of available origins per protocol. - Adjust tests - We temporarily break country code lookup which was handled previously with the "default-origin" mechanism. We will add it back to the CallsSettings class which will provide a better application-wide mechanism.
2021-04-13 09:36:58 +00:00
g_assert_cmpuint (g_list_model_get_n_items (origins), ==, 0);
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
g_assert_cmpuint (g_list_model_get_n_items (origins_tel), ==, 0);
Manager: add test
2020-03-20 17:33:59 +00:00
manager: Use state flags instead of an enum and adapt to changes This gives us some more granularity and is overall a better fit than the states previously used. Closes #327
2022-01-26 13:18:24 +00:00
g_assert_cmpuint (calls_manager_get_state_flags (manager), ==, CALLS_MANAGER_FLAGS_UNKNOWN);
manager: Delay UI Call removal and adjust to changes This was handled explicitly in the Call window. By changing the logic to delay the emission of "ui-call-removed" we make sure that the Call UI and the exported DBus object is consistent. We also need to change the test cases to use run a GMainLoop because we now have to wait until signal comes in.
2022-02-03 06:49:55 +00:00
g_assert_finalize_object (test_data->origin);
g_assert_finalize_object (test_data->manager);
g_free (test_data);
Manager: add test
2020-03-20 17:33:59 +00:00
}
static void
Fix old-style warnings all over the codebase As caught by compiling with `-Wold-style-definition` and `-Wstrict-prototypes`.
2021-06-02 18:18:50 +00:00
test_calls_manager_mm_provider (void)
Manager: add test
2020-03-20 17:33:59 +00:00
{
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
GListModel *origins_tel;
Manager: add test
2020-03-20 17:33:59 +00:00
g_autoptr (CallsManager) manager = calls_manager_new ();
test: manager: Use more appropriate `g_assert_*()` calls
2021-05-05 15:19:24 +00:00
g_assert_true (CALLS_IS_MANAGER (manager));
manager: Use state flags instead of an enum and adapt to changes This gives us some more granularity and is overall a better fit than the states previously used. Closes #327
2022-01-26 13:18:24 +00:00
g_assert_cmpuint (calls_manager_get_state_flags (manager), ==, CALLS_MANAGER_FLAGS_UNKNOWN);
Manager: add test
2020-03-20 17:33:59 +00:00
manager: support multiple providers This includes the following changes: - Introduce a `providers` hash table to keep track of multiple CallProvider's and remove the `provider` member - Remove `calls_manager_get_provider()` and `calls_manager_set_provider()` in favour of `calls_manager_add_provider()`, `calls_manager_remove_provider()` and `calls_manager_has_provider()` - Introduce a `origins` GListStore to keep track of available origins. `origins` is updated in `items_changed_cb()` when the origins of any CallsProvider are updated. - Adapt to changes with respect to `calls_manager_get_origins()`. - Introduce `origins_by_protocol` hash table to keep track of available origins per protocol. - Adjust tests - We temporarily break country code lookup which was handled previously with the "default-origin" mechanism. We will add it back to the CallsSettings class which will provide a better application-wide mechanism.
2021-04-13 09:36:58 +00:00
calls_manager_add_provider (manager, "mm");
test: manager: Expanded *has_provider() testing
2021-05-19 22:54:40 +00:00
g_assert_true (calls_manager_has_any_provider (manager));
g_assert_true (calls_manager_has_provider (manager, "mm"));
manager: Use state flags instead of an enum and adapt to changes This gives us some more granularity and is overall a better fit than the states previously used. Closes #327
2022-01-26 13:18:24 +00:00
g_assert_cmpuint (calls_manager_get_state_flags (manager), >, CALLS_MANAGER_FLAGS_UNKNOWN);
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
Manager: add test
2020-03-20 17:33:59 +00:00
g_assert_null (calls_manager_get_calls (manager));
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
origins_tel = calls_manager_get_suitable_origins (manager, "tel:+123456789");
g_assert_nonnull (origins_tel);
g_assert_cmpuint (g_list_model_get_n_items (origins_tel), ==, 0);
manager: support multiple providers This includes the following changes: - Introduce a `providers` hash table to keep track of multiple CallProvider's and remove the `provider` member - Remove `calls_manager_get_provider()` and `calls_manager_set_provider()` in favour of `calls_manager_add_provider()`, `calls_manager_remove_provider()` and `calls_manager_has_provider()` - Introduce a `origins` GListStore to keep track of available origins. `origins` is updated in `items_changed_cb()` when the origins of any CallsProvider are updated. - Adapt to changes with respect to `calls_manager_get_origins()`. - Introduce `origins_by_protocol` hash table to keep track of available origins per protocol. - Adjust tests - We temporarily break country code lookup which was handled previously with the "default-origin" mechanism. We will add it back to the CallsSettings class which will provide a better application-wide mechanism.
2021-04-13 09:36:58 +00:00
calls_manager_remove_provider (manager, "mm");
manager: Use state flags instead of an enum and adapt to changes This gives us some more granularity and is overall a better fit than the states previously used. Closes #327
2022-01-26 13:18:24 +00:00
g_assert_cmpuint (calls_manager_get_state_flags (manager), ==, CALLS_MANAGER_FLAGS_UNKNOWN);
Manager: add test
2020-03-20 17:33:59 +00:00
}
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
static void
Fix old-style warnings all over the codebase As caught by compiling with `-Wold-style-definition` and `-Wstrict-prototypes`.
2021-06-02 18:18:50 +00:00
test_calls_manager_multiple_providers_mm_sip (void)
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
{
g_autoptr (CallsOrigin) origin_alice = NULL;
g_autoptr (CallsOrigin) origin_bob = NULL;
g_autoptr (CallsManager) manager = calls_manager_new ();
GListModel *origins;
GListModel *origins_tel;
GListModel *origins_sip;
GListModel *origins_sips;
g_assert_true (CALLS_IS_MANAGER (manager));
origins = calls_manager_get_origins (manager);
g_assert_true (G_IS_LIST_MODEL (origins));
manager: Use state flags instead of an enum and adapt to changes This gives us some more granularity and is overall a better fit than the states previously used. Closes #327
2022-01-26 13:18:24 +00:00
g_assert_cmpuint (calls_manager_get_state_flags (manager), ==, CALLS_MANAGER_FLAGS_UNKNOWN);
manager: Hardcode supported protocols and adapt to changes This simplifies the code quite a bit by removing the supported protocols from being determined dynamically via the loaded plugins. It was previously used to add/remove a GListStore to origins_by_protocol. This is a prerequisite for having per protocol dial actions.
2022-01-26 07:24:09 +00:00
origins_tel = calls_manager_get_suitable_origins (manager, "tel:+123456789");
g_assert_nonnull (origins_tel);
g_assert_cmpuint (g_list_model_get_n_items (origins_tel), ==, 0);
origins_sip = calls_manager_get_suitable_origins (manager, "sip:alice@example.org");
g_assert_nonnull (origins_sip);
g_assert_cmpuint (g_list_model_get_n_items (origins_sip), ==, 0);
origins_sips = calls_manager_get_suitable_origins (manager, "sips:bob@example.org");
g_assert_nonnull (origins_sips);
g_assert_cmpuint (g_list_model_get_n_items (origins), ==, 0);
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
/* First add the SIP provider, MM provider later */
calls_manager_add_provider (manager, "sip");
test: manager: Expanded *has_provider() testing
2021-05-19 22:54:40 +00:00
g_assert_true (calls_manager_has_any_provider (manager));
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
g_assert_true (calls_manager_has_provider (manager, "sip"));
g_assert_true (calls_manager_is_modem_provider (manager, "sip") == FALSE);
manager: Use state flags instead of an enum and adapt to changes This gives us some more granularity and is overall a better fit than the states previously used. Closes #327
2022-01-26 13:18:24 +00:00
g_assert_cmpuint (calls_manager_get_state_flags (manager), ==, CALLS_MANAGER_FLAGS_HAS_VOIP_PROVIDER);
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
manager: Hardcode supported protocols and adapt to changes This simplifies the code quite a bit by removing the supported protocols from being determined dynamically via the loaded plugins. It was previously used to add/remove a GListStore to origins_by_protocol. This is a prerequisite for having per protocol dial actions.
2022-01-26 07:24:09 +00:00
/* Still no origins */
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
origins_tel = calls_manager_get_suitable_origins (manager, "tel:+123456789");
g_assert_cmpuint (g_list_model_get_n_items (origins_tel), ==, 0);
origins_sip = calls_manager_get_suitable_origins (manager, "sip:alice@example.org");
g_assert_cmpuint (g_list_model_get_n_items (origins_sip), ==, 0);
origins_sips = calls_manager_get_suitable_origins (manager, "sips:bob@example.org");
g_assert_cmpuint (g_list_model_get_n_items (origins_sips), ==, 0);
/**
manager: Use state flags instead of an enum and adapt to changes This gives us some more granularity and is overall a better fit than the states previously used. Closes #327
2022-01-26 13:18:24 +00:00
* If we now load the MM plugin, the manager flag _HAS_CELLULAR_PROVIDER should be set
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
* TODO DBus mock to add modems
* see https://source.puri.sm/Librem5/calls/-/issues/280
* and https://source.puri.sm/Librem5/calls/-/issues/178
*/
calls_manager_add_provider (manager, "mm");
test: manager: Expanded *has_provider() testing
2021-05-19 22:54:40 +00:00
g_assert_true (calls_manager_has_any_provider (manager));
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
g_assert_true (calls_manager_has_provider (manager, "mm"));
manager: Use state flags instead of an enum and adapt to changes This gives us some more granularity and is overall a better fit than the states previously used. Closes #327
2022-01-26 13:18:24 +00:00
g_assert_cmpuint (calls_manager_get_state_flags (manager), ==,
CALLS_MANAGER_FLAGS_HAS_VOIP_PROVIDER |
CALLS_MANAGER_FLAGS_HAS_CELLULAR_PROVIDER);
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
}
Manager: add test
2020-03-20 17:33:59 +00:00
gint
main (gint argc,
gchar *argv[])
{
gtk_test_init (&argc, &argv, NULL);
/* Add builddir as search path */
#ifdef PLUGIN_BUILDDIR
peas_engine_add_search_path (peas_engine_get_default (), PLUGIN_BUILDDIR, NULL);
#endif
g_test_add_func("/Calls/Manager/without_provider", test_calls_manager_without_provider);
g_test_add_func("/Calls/Manager/dummy_provider", test_calls_manager_dummy_provider);
g_test_add_func("/Calls/Manager/mm_provider", test_calls_manager_mm_provider);
tests: manager: Add multiple provider tests The test suite can be further expanded later. For now this suffices to have some basic regression testing for multiple provider support in place.
2021-05-05 18:53:37 +00:00
g_test_add_func("/Calls/Manager/multiple_provider_mm_sip", test_calls_manager_multiple_providers_mm_sip);
Manager: add test
2020-03-20 17:33:59 +00:00
return g_test_run();
}
Reference in a new issue Copy permalink