depau/HackMD
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
1326 commits 10 branches 17 tags 22 MiB
Commit graph

94 commits

Author SHA1 Message Date
Johannes Weißl 89a2389586 Correct documentation of S3 bucket 
Documentation added in aaf034b on Nov 17th 2016 says the S3 bucket can
be specified with `s3.bucket`, but commit c8bcc4c (#285) on Dec 18th
2016 used `s3bucket`. Instead of fixing the code (#552) to match the
documentation this commit changes just the documentation so that
existing configurations are not broken. Also, the `s3` object is passed
as is to `AWS.S3()`, which does not know the option `bucket` (but
silently ignores it in my test).

http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html#constructor-property

Following the old documentation leads to this exception:

    2017-09-23T09:42:38.079Z - error:  MissingRequiredParameter: Missing required key 'Bucket' in params
        at ParamValidator.fail (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/param_validator.js:50:37)
        at ParamValidator.validateStructure (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/param_validator.js:61:14)
        at ParamValidator.validateMember (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/param_validator.js:88:21)
        at ParamValidator.validate (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/param_validator.js:34:10)
        at Request.VALIDATE_PARAMETERS (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/event_listeners.js:125:42)
        at Request.callListeners (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/sequential_executor.js:105:20)
        at callNextListener (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/sequential_executor.js:95:12)
        at /srv/hackmd/hackmd/node_modules/aws-sdk/lib/event_listeners.js:85:9
        at finish (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/config.js:315:7)
        at /srv/hackmd/hackmd/node_modules/aws-sdk/lib/config.js:333:9
        at Credentials.get (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/credentials.js:126:7)
        at getAsyncCredentials (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/config.js:327:24)
        at Config.getCredentials (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/config.js:347:9)
        at Request.VALIDATE_CREDENTIALS (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/event_listeners.js:80:26)
        at Request.callListeners (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/sequential_executor.js:101:18)
        at Request.emit (/srv/hackmd/hackmd/node_modules/aws-sdk/lib/sequential_executor.js:77:10)
 2017-09-23 18:28:57 +02:00
Wonder Chang af58a71238 Add defaultpermission protected example value 2017-03-25 17:00:43 +08:00
Max Wu 16d80edc65 Fix badges and links in README.md 2017-03-14 23:30:35 +08:00
Wu Cheng-Han 506a381eca Add config option for gitlab api scope and auto adapt gitlab snippet feature on it 2017-03-14 18:04:23 +08:00
BoHong Li 8246ac3850 Add JavaScript Standard Style badge in README 
add badge to let people know that code is using the standard style
 2017-03-13 18:42:22 +08:00
bananaappletw c48ba0ad48 Test up to 7.5.0 2017-02-15 22:09:09 +08:00
bananaappletw 4198d0d560 Add travis ci 2017-02-15 19:11:53 +08:00
NV 00d1543a10 simplified description 2017-02-10 11:49:45 +09:00
NV a0d16eec23 Update README 2017-02-09 11:45:34 +09:00
Max Wu 6587e7ccc6 Merge pull request #343 from sakajunquality/feature/fix-read-me-for-gcc 
Add additional comment about Prerequisite to README
 2017-02-08 15:10:02 +08:00
Jun SAKATA 2ab57effbd add reference to packages, instead of writing down solutions for specific os 2017-02-08 15:30:31 +09:00
Wu Cheng-Han bbbf64aae4 Fix HMD_LDAP_TLS_CA not passing correctly and update README.md 2017-02-07 21:17:05 +08:00
Jun SAKATA c49a0849b2 add sudo 2017-02-06 17:48:08 +09:00
Jun SAKATA 373f32aab7 Add additional comment about Prerequisite to README 2017-02-06 17:41:46 +09:00
Yukai Huang 75e28a1d5e Merge branch 't216-refactor-common' into 'frontend-next' 
T216 refactor common

See merge request !5
 2017-01-15 03:45:19 +00:00
Yukai Huang c0e8306961 Merge branch 'frontend-next' into t216-refactor-common 2017-01-15 11:33:22 +08:00
bananaappletw 77994508e6 Update README.md for npm script 2017-01-14 15:27:24 +08:00
Yukai Huang 98c0cfc6a7 Update README 2017-01-14 15:24:31 +08:00
Yukai Huang 3d6b319216 Merge branch 'master' into frontend-next 2017-01-13 22:53:33 +08:00
Wu Cheng-Han 3cf40a8dec Update README.md to describe allowemailregister config more clear 2017-01-13 00:51:40 +08:00
Sheogorath 747629e549 Add allowemailregister option 2017-01-12 13:54:45 +01:00
neopostmodern ff545b2688 Allow displaying LDAP provider name on sign-in modal 2017-01-09 12:49:23 +01:00
Max Wu b13635aac9 Merge pull request #279 from alecdwm/ldap-auth 
Support for LDAP server authentication
 2017-01-09 00:49:40 +08:00
bananaappletw 78c51e5e88 Revert "Rename npm script" 
This reverts commit ed83dfc862.
 2017-01-04 14:30:47 +08:00
Wu Cheng-Han f9d2f68959 Update README.md about migration tool of version 0.5.0 2017-01-02 11:15:20 +08:00
bananaappletw 96fb3743f3 Use dburl to configurate 2016-12-22 21:51:48 +08:00
Florian Rhiem fdea226159 Fixed typo: anonmyous 2016-12-21 14:36:54 +01:00
Wu Cheng-Han 5bb3de2675 Add support of allow free url config option with correspond modifications 2016-12-16 15:38:05 +08:00
Wu Cheng-Han 5c7eb48319 Add support of allow anonymous config option with correspond modifications 2016-12-15 14:11:23 +08:00
alecdwm 6ba9a2f039 Added HMD_LDAP_TLS_CA env variable 2016-12-14 11:49:33 +01:00
alecdwm 02e9927714 Initial support for LDAP server authentication 
Limitations as of this commit:

- tlsOptions can only be specified in config.json, not as env vars
- authentication failures are not yet gracefully handled by the UI
  - instead the error message is shown on a blank page (/auth/ldap)
- no email address is associated with the LDAP user's account
- no picture/profile URL is associated with the LDAP user's account
- we might have to generate our own access + refresh tokens,
  because we aren't using oauth. The currently generated
  tokens are just a placeholder.
- 'LDAP Sign in' needs to be translated to each locale
 2016-12-13 22:41:07 +01:00
Max Wu 9769b0c872 Update README.md 
to mention about build front-end bundle on upgrade guide
 2016-12-11 23:24:04 +08:00
Yukai Huang 9e6fd505e1 Remove bower occurences 2016-12-11 11:18:08 +08:00
Yukai Huang ed83dfc862 Rename npm script 
webpack scripts are meant to “build” assets, so place them under the same namespace

* dev => build:dev
* build => build:prod
 2016-12-10 22:12:07 +08:00
Wu Cheng-Han a73d9ce39e Update to support optional email register and signin 2016-12-02 01:58:14 +08:00
Yukai Huang aaf034bfbc Update README 2016-11-17 18:27:53 +08:00
Max Wu 58533aded3 Update README.md 
browser requirement of chrome to 47 in order to avoid SRI not valid issue https://bugs.chromium.org/p/chromium/issues/detail?id=527286
 2016-10-31 15:32:36 +08:00
Wu Cheng-Han d37321e28d Change use cdn config option default to be true 2016-10-23 22:27:02 +08:00
Yukai Huang 9f63581c61 Config heroku deployment 2016-10-16 11:20:29 +08:00
Max Wu 432106b7c6 Update README.md 
add charset requirement about DB, refer to issue #208
 2016-10-16 00:53:33 +08:00
Wu Cheng-Han 7edd39846c Update README.md about front-end bundle process 2016-10-15 14:35:31 +08:00
Max Wu 422d9cd4ee Update README.md 2016-10-11 12:43:19 +08:00
Wu Cheng-Han dfc8aeeba0 Add more environment variables for server configuration, update related section in README.md 2016-10-10 21:16:58 +08:00
Wu Cheng-Han bf4c6d021c Extract config.js from common.js to make client setting file clean and also make upgrade easier 2016-10-10 16:25:51 +08:00
Yukai Huang ec8fb1931b Update REAME setup script description 2016-10-05 14:17:32 +08:00
Yukai Huang 6f53d40d6a Update README get started section 2016-10-05 12:12:45 +08:00
Max Wu f4d4eb1681 Update README.md 2016-10-04 18:05:30 +08:00
Yukai Huang 0ba06df7bc Fix README markdown 2016-10-04 16:41:26 +08:00
Laura Kyle 5951611840 Update README.md 2016-10-02 23:00:54 -04:00
Laura Kyle 715fdcf657 Update README.md 2016-10-02 22:33:30 -04:00