depau/HackMD
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix sortOnlineUserList might not check property existence before comparsion

Browse source
This commit is contained in:
Wu Cheng-Han 2017-01-12 17:17:36 +08:00
parent fc788e805e
commit ffa14cfeef
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
public/js/index.js
View file

@ -2946,14 +2946,14 @@ function sortOnlineUserList(list) {
else if (usera.idle && !userb.idle) else if (usera.idle && !userb.idle)
return 1; return 1;
else { else {
if (usera.name && usera.name.toLowerCase() < userb.name.toLowerCase()) { if (usera.name && userb.name && usera.name.toLowerCase() < userb.name.toLowerCase()) {
return -1; return -1;
} else if (usera.name && usera.name.toLowerCase() > userb.name.toLowerCase()) { } else if (usera.name && userb.name && usera.name.toLowerCase() > userb.name.toLowerCase()) {
return 1; return 1;
} else { } else {
if (usera.color && usera.color.toLowerCase() < userb.color.toLowerCase()) if (usera.color && userb.color && usera.color.toLowerCase() < userb.color.toLowerCase())
return -1; return -1;
else if (usera.color && usera.color.toLowerCase() > userb.color.toLowerCase()) else if (usera.color && userb.color && usera.color.toLowerCase() > userb.color.toLowerCase())
return 1; return 1;
else else
return 0; return 0;