depau/HackMD
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix callback validation

Browse source 
Signed-off-by: Adam Hoka <hoka.adam@nexogen.hu>
This commit is contained in:
Adam Hoka 2018-06-01 13:01:57 +02:00
parent 65544f9a18
commit b5574466cd
4 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/web/imageRouter/filesystem.js
View file

@ -2,6 +2,7 @@
const url = require('url') const url = require('url')
const config = require('../../config') const config = require('../../config')
const logger = require('../../logger')
exports.uploadImage = function (imagePath, callback) { exports.uploadImage = function (imagePath, callback) {
if (!imagePath || typeof imagePath !== 'string') { if (!imagePath || typeof imagePath !== 'string') {
@ -10,7 +11,7 @@ exports.uploadImage = function (imagePath, callback) {
} }
if (!callback || typeof callback !== 'function') { if (!callback || typeof callback !== 'function') {
callback(new Error('Callback has to be a function'), null) logger.error('Callback has to be a function')
return return
} }

2
lib/web/imageRouter/imgur.js
View file

@ -11,7 +11,7 @@ exports.uploadImage = function (imagePath, callback) {
} }
if (!callback || typeof callback !== 'function') { if (!callback || typeof callback !== 'function') {
callback(new Error('Callback has to be a function'), null) logger.error('Callback has to be a function')
return return
} }

3
lib/web/imageRouter/minio.js
View file

@ -4,6 +4,7 @@ const path = require('path')
const config = require('../../config') const config = require('../../config')
const {getImageMimeType} = require('../../utils') const {getImageMimeType} = require('../../utils')
const logger = require('../../logger')
const Minio = require('minio') const Minio = require('minio')
const minioClient = new Minio.Client({ const minioClient = new Minio.Client({
@ -21,7 +22,7 @@ exports.uploadImage = function (imagePath, callback) {
} }
if (!callback || typeof callback !== 'function') { if (!callback || typeof callback !== 'function') {
callback(new Error('Callback has to be a function'), null) logger.error('Callback has to be a function')
return return
} }

3
lib/web/imageRouter/s3.js
View file

@ -4,6 +4,7 @@ const path = require('path')
const config = require('../../config') const config = require('../../config')
const {getImageMimeType} = require('../../utils') const {getImageMimeType} = require('../../utils')
const logger = require('../../logger')
const AWS = require('aws-sdk') const AWS = require('aws-sdk')
const awsConfig = new AWS.Config(config.s3) const awsConfig = new AWS.Config(config.s3)
@ -16,7 +17,7 @@ exports.uploadImage = function (imagePath, callback) {
} }
if (!callback || typeof callback !== 'function') { if (!callback || typeof callback !== 'function') {
callback(new Error('Callback has to be a function'), null) logger.error('Callback has to be a function')
return return
} }