depau/HackMD
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

fixed the SAML callback URL to unconfigurable.

Browse source
This commit is contained in:
Norihito Nakae 2017-11-29 15:45:32 +09:00
parent 4a4ae9d332
commit a22be81feb
3 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
config.json.example
View file

@ -79,7 +79,6 @@
"idpSsoUrl": "change: authentication endpoint of IdP", "idpSsoUrl": "change: authentication endpoint of IdP",
"idpCert": "change: certificate file path of IdP in PEM format", "idpCert": "change: certificate file path of IdP in PEM format",
"issuer": "change or delete: identity of the service provider (default: serverurl)", "issuer": "change or delete: identity of the service provider (default: serverurl)",
"callbackUrl": "change or delete: callback url to consume assertions (default: serverurl+'/auth/saml/callback')",
"identifierFormat": "change or delete: name identifier format (default: 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress')", "identifierFormat": "change or delete: name identifier format (default: 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress')",
"groupAttribute": "change or delete: attribute name for group list (ex: memberOf)", "groupAttribute": "change or delete: attribute name for group list (ex: memberOf)",
"requiredGroups": [ "change or delete: group names that allowed" ], "requiredGroups": [ "change or delete: group names that allowed" ],

1
lib/config/default.js
View file

@ -102,7 +102,6 @@ module.exports = {
idpSsoUrl: undefined, idpSsoUrl: undefined,
idpCert: undefined, idpCert: undefined,
issuer: undefined, issuer: undefined,
callbackUrl: undefined,
identifierFormat: 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress', identifierFormat: 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress',
groupAttribute: undefined, groupAttribute: undefined,
externalGroups: [], externalGroups: [],

2
lib/web/auth/saml/index.js
View file

@ -13,7 +13,7 @@ const intersection = function (array1, array2) { return array1.filter((n) => arr
let samlAuth = module.exports = Router() let samlAuth = module.exports = Router()
passport.use(new SamlStrategy({ passport.use(new SamlStrategy({
callbackUrl: config.saml.callbackUrl || config.serverurl + '/auth/saml/callback', callbackUrl: config.serverurl + '/auth/saml/callback',
entryPoint: config.saml.idpSsoUrl, entryPoint: config.saml.idpSsoUrl,
issuer: config.saml.issuer || config.serverurl, issuer: config.saml.issuer || config.serverurl,
cert: fs.readFileSync(config.saml.idpCert, 'utf-8'), cert: fs.readFileSync(config.saml.idpCert, 'utf-8'),