depau/HackMD
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Add check for noteId length

Browse source 
As we know the length of an UUID we can check if the base64 string
of the provided UUID is long enough for a legacy base64 encoded nodeId
and stop processing it in legacy mode, if it's not the case.

This should make the ugly warning way less common.

Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
This commit is contained in:
Sheogorath 2018-04-09 22:27:17 +02:00
parent bdb8631a7b
commit 735b806d5d
No known key found for this signature in database
GPG key ID: 1F05CC3635CDDFFD
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/models/note.js
View file

@ -211,6 +211,15 @@ module.exports = function (sequelize, DataTypes) {
}, },
// parse note id by LZString is deprecated, here for compability // parse note id by LZString is deprecated, here for compability
parseNoteIdByLZString: function (_callback) { parseNoteIdByLZString: function (_callback) {
// Calculate minimal string length for an UUID that is encoded
// base64 encoded and optimize comparsion by using -1
// this should make a lot of LZ-String parsing errors obsolete
// as we can assume that a nodeId that is 48 chars or longer is a
// noteID.
const base64UuidLength = ((4 * 36) / 3) - 1
if (!(noteId.length > base64UuidLength)) {
return _callback(null, null)
}
// try to parse note id by LZString Base64 // try to parse note id by LZString Base64
try { try {
var id = LZString.decompressFromBase64(noteId) var id = LZString.decompressFromBase64(noteId)