depau/HackMD
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

InternalOAuthError is not part of passport, but of passport-oauth2

Browse source 
This fixes part of #1056: an error while obtaining the profile
would have `502`-crashed the server.

Signed-off-by: Claudius Coenen <opensource@amenthes.de>
This commit is contained in:
Claudius Coenen 2018-11-14 10:39:43 +01:00
parent df2a2e6c6c
commit 56c043424d
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/web/auth/oauth2/index.js
View file

@ -2,13 +2,13 @@
const Router = require('express').Router const Router = require('express').Router
const passport = require('passport') const passport = require('passport')
const OAuth2Strategy = require('passport-oauth2').Strategy const { Strategy, InternalOAuthError } = require('passport-oauth2')
const config = require('../../../config') const config = require('../../../config')
const {setReturnToFromReferer, passportGeneralCallback} = require('../utils') const {setReturnToFromReferer, passportGeneralCallback} = require('../utils')
let oauth2Auth = module.exports = Router() let oauth2Auth = module.exports = Router()
class OAuth2CustomStrategy extends OAuth2Strategy { class OAuth2CustomStrategy extends Strategy {
constructor (options, verify) { constructor (options, verify) {
options.customHeaders = options.customHeaders || {} options.customHeaders = options.customHeaders || {}
super(options, verify) super(options, verify)
@ -22,7 +22,7 @@ class OAuth2CustomStrategy extends OAuth2Strategy {
var json var json
if (err) { if (err) {
return done(new passport.InternalOAuthError('Failed to fetch user profile', err)) return done(new InternalOAuthError('Failed to fetch user profile', err))
} }
try { try {
@ -67,7 +67,7 @@ OAuth2CustomStrategy.prototype.userProfile = function (accessToken, done) {
var json var json
if (err) { if (err) {
return done(new passport.InternalOAuthError('Failed to fetch user profile', err)) return done(new InternalOAuthError('Failed to fetch user profile', err))
} }
try { try {