depau/HackMD
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #811 from hackmdio/fix-saml-typo

Browse source 
Fix typo of "grouptAttribute" in saml auth module
This commit is contained in:
Christoph (Sheogorath) Kern 2018-04-28 01:13:39 +02:00 committed by GitHub
commit 2232905c4a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/web/auth/saml/index.js
View file

@ -20,14 +20,14 @@ passport.use(new SamlStrategy({
identifierFormat: config.saml.identifierFormat identifierFormat: config.saml.identifierFormat
}, function (user, done) { }, function (user, done) {
// check authorization if needed // check authorization if needed
if (config.saml.externalGroups && config.saml.grouptAttribute) { if (config.saml.externalGroups && config.saml.groupAttribute) {
var externalGroups = intersection(config.saml.externalGroups, user[config.saml.groupAttribute]) var externalGroups = intersection(config.saml.externalGroups, user[config.saml.groupAttribute])
if (externalGroups.length > 0) { if (externalGroups.length > 0) {
logger.error('saml permission denied: ' + externalGroups.join(', ')) logger.error('saml permission denied: ' + externalGroups.join(', '))
return done('Permission denied', null) return done('Permission denied', null)
} }
} }
if (config.saml.requiredGroups && config.saml.grouptAttribute) { if (config.saml.requiredGroups && config.saml.groupAttribute) {
if (intersection(config.saml.requiredGroups, user[config.saml.groupAttribute]).length === 0) { if (intersection(config.saml.requiredGroups, user[config.saml.groupAttribute]).length === 0) {
logger.error('saml permission denied') logger.error('saml permission denied')
return done('Permission denied', null) return done('Permission denied', null)