depau/HackMD
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #797 from SISheogorath/fix/LZErrorLog

Browse source 
Add check for noteId length
This commit is contained in:
Christoph (Sheogorath) Kern 2018-04-11 22:48:40 +02:00 committed by GitHub
commit 10121118fb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/models/note.js
View file

@ -211,6 +211,15 @@ module.exports = function (sequelize, DataTypes) {
}, },
// parse note id by LZString is deprecated, here for compability // parse note id by LZString is deprecated, here for compability
parseNoteIdByLZString: function (_callback) { parseNoteIdByLZString: function (_callback) {
// Calculate minimal string length for an UUID that is encoded
// base64 encoded and optimize comparsion by using -1
// this should make a lot of LZ-String parsing errors obsolete
// as we can assume that a nodeId that is 48 chars or longer is a
// noteID.
const base64UuidLength = ((4 * 36) / 3) - 1
if (!(noteId.length > base64UuidLength)) {
return _callback(null, null)
}
// try to parse note id by LZString Base64 // try to parse note id by LZString Base64
try { try {
var id = LZString.decompressFromBase64(noteId) var id = LZString.decompressFromBase64(noteId)