depau/HackMD
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Fix usage of new URL API

Browse source 
Due to the deprecation of the old `url`-API provided by NodeJS we
replaced `url.resolve` with `url.URL.resolve`, which doesn't exist.

This patch fixes the local filesystem upload of CodiMD by using the new
API correctly. Creating an URL object and using its href.

Some more background:
https://nodejs.org/api/url.html#url_url_href
https://nodejs.org/api/url.html#url_url_resolve_from_to

Fixes https://github.com/hackmdio/codimd/issues/1102

Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
This commit is contained in:
Sheogorath 2018-12-18 14:52:09 +01:00
parent b40f14f66d
commit 0621d7a72d
No known key found for this signature in database
GPG key ID: 1F05CC3635CDDFFD
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lib/web/imageRouter/filesystem.js
View file

@ -1,5 +1,5 @@
'use strict' 'use strict'
const url = require('url') const URL = require('url').URL
const path = require('path') const path = require('path')
const config = require('../../config') const config = require('../../config')
@ -16,5 +16,5 @@ exports.uploadImage = function (imagePath, callback) {
return return
} }
callback(null, url.URL.resolve(config.serverURL + '/uploads/', path.basename(imagePath))) callback(null, (new URL(path.basename(imagePath), config.serverURL + '/uploads/')).href)
} }